Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "5.0.0 - remove computed keys from JSON in monitoring dashboar… #9538

Closed
wants to merge 1 commit into from

Conversation

etruong42
Copy link
Member

…d (#9065)"

This reverts commit 262bbe6.

That commit introduced the issue at hashicorp/terraform-provider-google#16439

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 29, 2023
@melinath
Copy link
Member

This would reintroduce hashicorp/terraform-provider-google#7242, which was fixed by #9065 (which this reverts). Additionally, this would likely be a breaking change (since the reverted PR was a breaking change) and re-introducing the reverted PR would definitely be a breaking change. We should likely fix-forward in this case instead, since the code as written works in most cases.

@melinath melinath closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants