Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The version field should be under configmanagement instead of under oci, deprecating the older field #9648

Merged
merged 62 commits into from
Dec 15, 2023
Merged
Show file tree
Hide file tree
Changes from 61 commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
85298f1
Adding Terraform resources for Tenancy APIs in GKEHub
sahsagar-google Jul 19, 2023
05f9e1d
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Jul 20, 2023
d056843
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Jul 24, 2023
20fea52
Segregating MembershipBinding and MembershipRBACRoleBinding to keep t…
sahsagar-google Jul 24, 2023
672494c
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Aug 2, 2023
3a4cefa
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Aug 10, 2023
693aaff
Fixing the docu URIs
sahsagar-google Aug 10, 2023
1d65988
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Aug 11, 2023
d783ddd
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Aug 11, 2023
bc96cbb
Adding TF support for Tenancy API for Membership Binding
sahsagar-google Jul 24, 2023
f74ce0f
Adding dependent membership binding to the same commit chain
sahsagar-google Aug 11, 2023
e0c2212
Making Scope un-updatable and replacing hard coded project number wit…
sahsagar-google Aug 12, 2023
c77f8b2
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Aug 14, 2023
71c92e6
Making Scope RRBAC updatable
sahsagar-google Aug 15, 2023
2403caa
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Aug 15, 2023
308091c
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Aug 15, 2023
a0f99d5
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Aug 15, 2023
78c9611
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Aug 22, 2023
45ee3fc
Making Namespace immutable
sahsagar-google Aug 22, 2023
4852207
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Aug 24, 2023
79a8e93
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Aug 25, 2023
db46dd0
Adding update test cases
sahsagar-google Aug 25, 2023
1cb54db
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Aug 28, 2023
f574890
Removing all memberships field from Scope since it is no longer suppo…
sahsagar-google Aug 28, 2023
35ea32e
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Aug 29, 2023
dd80ce3
Removing all_memberships field for Scope from all test cases
sahsagar-google Aug 29, 2023
371905f
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Aug 30, 2023
ad76f8b
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Aug 30, 2023
3d51fc1
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Aug 31, 2023
61ed74c
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Sep 1, 2023
5dd7c9d
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Sep 6, 2023
db7d7d2
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Sep 11, 2023
b72eff4
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Sep 12, 2023
0093110
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Sep 18, 2023
cdccf65
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Sep 18, 2023
6db5284
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Sep 25, 2023
1155b69
Making naming in examples consistent across Tenancy APIs documentation
sahsagar-google Sep 25, 2023
ae622c8
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Sep 25, 2023
a26ddad
Update mmv1/templates/terraform/examples/gkehub_membership_binding_ba…
sahsagar-google Sep 26, 2023
b351bd4
Update mmv1/templates/terraform/examples/gkehub_membership_binding_ba…
sahsagar-google Sep 26, 2023
92e20e3
Update mmv1/templates/terraform/examples/gkehub_membership_rbac_role_…
sahsagar-google Sep 26, 2023
9c1f15c
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Sep 26, 2023
f4e7c9e
Fixing typo in the resource name
sahsagar-google Sep 26, 2023
4a799e5
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Sep 27, 2023
ae81472
Adding state migrations for Membership
sahsagar-google Sep 27, 2023
98814d2
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Oct 9, 2023
e9f3de1
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Oct 11, 2023
4aab86c
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Oct 16, 2023
11e1ea9
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Oct 23, 2023
29858ff
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Oct 31, 2023
0a9a1b6
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Nov 14, 2023
819c315
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Nov 21, 2023
4fdc043
Updating the feature_membership documentation with the current resour…
sahsagar-google Nov 21, 2023
0a94d2e
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Dec 5, 2023
e4c6983
Fixing the version field to be directly under configmanagement instea…
sahsagar-google Dec 5, 2023
6cd2070
Adding tests for the field version
sahsagar-google Dec 12, 2023
7dc3a1f
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Dec 12, 2023
14b6fc2
Changing version fields value to test upgradation
sahsagar-google Dec 12, 2023
46179b1
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Dec 13, 2023
3a3b389
Merge branch 'GoogleCloudPlatform:main' into main
sahsagar-google Dec 14, 2023
4ab36d5
Moving the version to under the parent field configmanagement
sahsagar-google Dec 14, 2023
791ef71
Adding quotes around the fields name
sahsagar-google Dec 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mmv1/products/gkehub2/Feature.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,9 @@ properties:
name: configmanagement
description: Config Management spec
properties:
- !ruby/object:Api::Type::String
name: version
description: 'Version of ACM installed'
- !ruby/object:Api::Type::NestedObject
name: configSync
description: 'ConfigSync configuration for the cluster'
Expand Down Expand Up @@ -274,6 +277,7 @@ properties:
- !ruby/object:Api::Type::String
name: version
description: 'Version of ACM installed'
deprecation_message: The configmanagement.config_sync.oci.version field is deprecated and will be removed in a future major release. Please use configmanagement.version field to specify the version of ACM installed instead.
sahsagar-google marked this conversation as resolved.
Show resolved Hide resolved
- !ruby/object:Api::Type::NestedObject
name: policycontroller
description: Policy Controller spec
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,7 @@ resource "google_gke_hub_feature" "feature" {
location = "global"
fleet_default_member_config {
configmanagement {
version = "1.16.0"
config_sync {
source_format = "hierarchy"
git {
Expand All @@ -486,6 +487,7 @@ resource "google_gke_hub_feature" "feature" {
location = "global"
fleet_default_member_config {
configmanagement {
version = "1.16.1"
config_sync {
source_format = "unstructured"
oci {
Expand Down