Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move local variables in resource.erb #9735

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Jan 2, 2024

move local variables and logic from resource.erb -> resource.rb

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@c2thorn
Copy link
Member Author

c2thorn commented Jan 2, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@c2thorn c2thorn requested a review from zli82016 January 2, 2024 22:34
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016
Copy link
Member

zli82016 commented Jan 2, 2024

If there is more work I can help, feel free to let me know.

@c2thorn c2thorn merged commit 163480b into GoogleCloudPlatform:main Jan 3, 2024
11 checks passed
kylase pushed a commit to yuanchuankee/magic-modules that referenced this pull request Jan 21, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants