-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#15779] Add google_network_security_firewall_endpoint resource #9813
[#15779] Add google_network_security_firewall_endpoint resource #9813
Conversation
Hello! I am a robot. It looks like you are a: @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
d57ce70
to
5215dea
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 152 insertions(+)) |
Tests analyticsTotal tests: Click here to see the affected service packages
|
c97bd62
to
c4acd2c
Compare
Tests analyticsTotal tests: Click here to see the affected service packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, just a few minor suggestions
...y/terraform/services/networksecurity/resource_network_security_firewall_endpoint_test.go.erb
Show resolved
Hide resolved
c4acd2c
to
3addb61
Compare
@roaks3 replies to all comments. I think we're ready for another round of review :) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 152 insertions(+)) |
Tests analyticsTotal tests: Click here to see the affected service packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests pass
…leCloudPlatform#9813) * [#15779] Add google_network_security_firewall_endpoint resource * Fix yaml linting * Removing unused fields from yaml * Fixing tests * Fixes per comments --------- Co-authored-by: Luca Prete <[email protected]>
* add labels to runtime update test * Add desired_state for workbench instances * fix(tgc): Fixing the if block for existingConverterAsset and add test case (#9914) * Add sweepers for vertex_dataset, vertex_tensorboard and vertex_metadataStore (#9911) * Make acctest use bootstrapped KMS key, instead of making new key that resembles a shared key (#9926) * Refactor the TeamCity config to define all projects, across GA, Beta, and VCR testing (#9837) * Replace contents of .teamcity/ with new refactored config files * Remove remaining automation for generating service lists automatically * Remove copyright headers, as they're added during generation process * Update header comments on .teamcity files * Make VCR testing compatible with TeamCity agent * Update GA + Beta service lists to match the currrent provider * Fix whitespace * Update default TEST ENV value for VCR builds * Add chmod commands to handling of creds file * Update pre- and post-VCR steps to echo out more information about their actions * Rename `generated` folder to `inputs` * Update header comments on .teamcity files * Refactor how VCR recording buid configurations are made * Fix comment on MM VCR build * Update VCR post step to fail if no cassettes are produced by the tests before * Whitespace changes * Fix how teamcity files are copied to the downstreams * Change how VCR build configs are named * remove newlines * Fix defect in post VCR build steps * Refactor labelling that indicates automated vs ad hoc builds * Make VCR builds be triggered to indicate VCR_MODE * Add first version of TeamCity documentation! * Add contents section to PERFORMING_TASKS_IN_TEAMCITY.md * Move details about DSL into technical README, away from process doc * Make the .teamcity folder only propogate to the TPG repo, and no longer be in the TPGB repo * Ensure all TeamCity files are being copied to the downstream repo * Move echo command to after `BRANCH_NAME` ENV declared * Update VCR steps to look for fixtures files inside beta folder * Update mmv1/third_party/terraform/.teamcity/components/builds/vcr_build_steps.kt Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/.teamcity/CONTRIBUTION_GUIDE.md Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * [#15779] Add google_network_security_firewall_endpoint resource (#9813) * [#15779] Add google_network_security_firewall_endpoint resource * Fix yaml linting * Removing unused fields from yaml * Fixing tests * Fixes per comments --------- Co-authored-by: Luca Prete <[email protected]> * enhancement: Allow overriding the Billing Project for google_cloud_asset_resources_search_all (#9935) * enhancement: Allow overriding the Billing Project for cloud_asset_resources_search_all * chore: Fixed indentation * Add firebaseappcheck to service package lists (#9937) * Enable CRONs in TeamCity (#9938) * Set CRONs for 4am UTC * Enable CRONs * Update enrolled_teams.yml (#9939) * add NickElliot to vacation reviewers (#9942) * Update membership.go * Update membership.go * fix lint issues * fix conversion compilation * Remove Runtime example * Add back kms flatten * change encryption to CMEK to test for KMS * Try using a global KMS key * kms key location to us-central1 * remove service account in full example * Adding back service account into full test --------- Co-authored-by: Iris Chen <[email protected]> Co-authored-by: hao-nan-li <[email protected]> Co-authored-by: Sarah French <[email protected]> Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Koen van Zuijlen <[email protected]> Co-authored-by: Ryan Oaks <[email protected]> Co-authored-by: Nick Elliot <[email protected]>
…leCloudPlatform#9813) * [#15779] Add google_network_security_firewall_endpoint resource * Fix yaml linting * Removing unused fields from yaml * Fixing tests * Fixes per comments --------- Co-authored-by: Luca Prete <[email protected]>
* add labels to runtime update test * Add desired_state for workbench instances * fix(tgc): Fixing the if block for existingConverterAsset and add test case (GoogleCloudPlatform#9914) * Add sweepers for vertex_dataset, vertex_tensorboard and vertex_metadataStore (GoogleCloudPlatform#9911) * Make acctest use bootstrapped KMS key, instead of making new key that resembles a shared key (GoogleCloudPlatform#9926) * Refactor the TeamCity config to define all projects, across GA, Beta, and VCR testing (GoogleCloudPlatform#9837) * Replace contents of .teamcity/ with new refactored config files * Remove remaining automation for generating service lists automatically * Remove copyright headers, as they're added during generation process * Update header comments on .teamcity files * Make VCR testing compatible with TeamCity agent * Update GA + Beta service lists to match the currrent provider * Fix whitespace * Update default TEST ENV value for VCR builds * Add chmod commands to handling of creds file * Update pre- and post-VCR steps to echo out more information about their actions * Rename `generated` folder to `inputs` * Update header comments on .teamcity files * Refactor how VCR recording buid configurations are made * Fix comment on MM VCR build * Update VCR post step to fail if no cassettes are produced by the tests before * Whitespace changes * Fix how teamcity files are copied to the downstreams * Change how VCR build configs are named * remove newlines * Fix defect in post VCR build steps * Refactor labelling that indicates automated vs ad hoc builds * Make VCR builds be triggered to indicate VCR_MODE * Add first version of TeamCity documentation! * Add contents section to PERFORMING_TASKS_IN_TEAMCITY.md * Move details about DSL into technical README, away from process doc * Make the .teamcity folder only propogate to the TPG repo, and no longer be in the TPGB repo * Ensure all TeamCity files are being copied to the downstream repo * Move echo command to after `BRANCH_NAME` ENV declared * Update VCR steps to look for fixtures files inside beta folder * Update mmv1/third_party/terraform/.teamcity/components/builds/vcr_build_steps.kt Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/.teamcity/CONTRIBUTION_GUIDE.md Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * [#15779] Add google_network_security_firewall_endpoint resource (GoogleCloudPlatform#9813) * [#15779] Add google_network_security_firewall_endpoint resource * Fix yaml linting * Removing unused fields from yaml * Fixing tests * Fixes per comments --------- Co-authored-by: Luca Prete <[email protected]> * enhancement: Allow overriding the Billing Project for google_cloud_asset_resources_search_all (GoogleCloudPlatform#9935) * enhancement: Allow overriding the Billing Project for cloud_asset_resources_search_all * chore: Fixed indentation * Add firebaseappcheck to service package lists (GoogleCloudPlatform#9937) * Enable CRONs in TeamCity (GoogleCloudPlatform#9938) * Set CRONs for 4am UTC * Enable CRONs * Update enrolled_teams.yml (GoogleCloudPlatform#9939) * add NickElliot to vacation reviewers (GoogleCloudPlatform#9942) * Update membership.go * Update membership.go * fix lint issues * fix conversion compilation * Remove Runtime example * Add back kms flatten * change encryption to CMEK to test for KMS * Try using a global KMS key * kms key location to us-central1 * remove service account in full example * Adding back service account into full test --------- Co-authored-by: Iris Chen <[email protected]> Co-authored-by: hao-nan-li <[email protected]> Co-authored-by: Sarah French <[email protected]> Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Koen van Zuijlen <[email protected]> Co-authored-by: Ryan Oaks <[email protected]> Co-authored-by: Nick Elliot <[email protected]>
…leCloudPlatform#9813) * [#15779] Add google_network_security_firewall_endpoint resource * Fix yaml linting * Removing unused fields from yaml * Fixing tests * Fixes per comments --------- Co-authored-by: Luca Prete <[email protected]>
* add labels to runtime update test * Add desired_state for workbench instances * fix(tgc): Fixing the if block for existingConverterAsset and add test case (GoogleCloudPlatform#9914) * Add sweepers for vertex_dataset, vertex_tensorboard and vertex_metadataStore (GoogleCloudPlatform#9911) * Make acctest use bootstrapped KMS key, instead of making new key that resembles a shared key (GoogleCloudPlatform#9926) * Refactor the TeamCity config to define all projects, across GA, Beta, and VCR testing (GoogleCloudPlatform#9837) * Replace contents of .teamcity/ with new refactored config files * Remove remaining automation for generating service lists automatically * Remove copyright headers, as they're added during generation process * Update header comments on .teamcity files * Make VCR testing compatible with TeamCity agent * Update GA + Beta service lists to match the currrent provider * Fix whitespace * Update default TEST ENV value for VCR builds * Add chmod commands to handling of creds file * Update pre- and post-VCR steps to echo out more information about their actions * Rename `generated` folder to `inputs` * Update header comments on .teamcity files * Refactor how VCR recording buid configurations are made * Fix comment on MM VCR build * Update VCR post step to fail if no cassettes are produced by the tests before * Whitespace changes * Fix how teamcity files are copied to the downstreams * Change how VCR build configs are named * remove newlines * Fix defect in post VCR build steps * Refactor labelling that indicates automated vs ad hoc builds * Make VCR builds be triggered to indicate VCR_MODE * Add first version of TeamCity documentation! * Add contents section to PERFORMING_TASKS_IN_TEAMCITY.md * Move details about DSL into technical README, away from process doc * Make the .teamcity folder only propogate to the TPG repo, and no longer be in the TPGB repo * Ensure all TeamCity files are being copied to the downstream repo * Move echo command to after `BRANCH_NAME` ENV declared * Update VCR steps to look for fixtures files inside beta folder * Update mmv1/third_party/terraform/.teamcity/components/builds/vcr_build_steps.kt Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/.teamcity/CONTRIBUTION_GUIDE.md Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * [#15779] Add google_network_security_firewall_endpoint resource (GoogleCloudPlatform#9813) * [#15779] Add google_network_security_firewall_endpoint resource * Fix yaml linting * Removing unused fields from yaml * Fixing tests * Fixes per comments --------- Co-authored-by: Luca Prete <[email protected]> * enhancement: Allow overriding the Billing Project for google_cloud_asset_resources_search_all (GoogleCloudPlatform#9935) * enhancement: Allow overriding the Billing Project for cloud_asset_resources_search_all * chore: Fixed indentation * Add firebaseappcheck to service package lists (GoogleCloudPlatform#9937) * Enable CRONs in TeamCity (GoogleCloudPlatform#9938) * Set CRONs for 4am UTC * Enable CRONs * Update enrolled_teams.yml (GoogleCloudPlatform#9939) * add NickElliot to vacation reviewers (GoogleCloudPlatform#9942) * Update membership.go * Update membership.go * fix lint issues * fix conversion compilation * Remove Runtime example * Add back kms flatten * change encryption to CMEK to test for KMS * Try using a global KMS key * kms key location to us-central1 * remove service account in full example * Adding back service account into full test --------- Co-authored-by: Iris Chen <[email protected]> Co-authored-by: hao-nan-li <[email protected]> Co-authored-by: Sarah French <[email protected]> Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Koen van Zuijlen <[email protected]> Co-authored-by: Ryan Oaks <[email protected]> Co-authored-by: Nick Elliot <[email protected]>
…leCloudPlatform#9813) * [#15779] Add google_network_security_firewall_endpoint resource * Fix yaml linting * Removing unused fields from yaml * Fixing tests * Fixes per comments --------- Co-authored-by: Luca Prete <[email protected]>
* add labels to runtime update test * Add desired_state for workbench instances * fix(tgc): Fixing the if block for existingConverterAsset and add test case (GoogleCloudPlatform#9914) * Add sweepers for vertex_dataset, vertex_tensorboard and vertex_metadataStore (GoogleCloudPlatform#9911) * Make acctest use bootstrapped KMS key, instead of making new key that resembles a shared key (GoogleCloudPlatform#9926) * Refactor the TeamCity config to define all projects, across GA, Beta, and VCR testing (GoogleCloudPlatform#9837) * Replace contents of .teamcity/ with new refactored config files * Remove remaining automation for generating service lists automatically * Remove copyright headers, as they're added during generation process * Update header comments on .teamcity files * Make VCR testing compatible with TeamCity agent * Update GA + Beta service lists to match the currrent provider * Fix whitespace * Update default TEST ENV value for VCR builds * Add chmod commands to handling of creds file * Update pre- and post-VCR steps to echo out more information about their actions * Rename `generated` folder to `inputs` * Update header comments on .teamcity files * Refactor how VCR recording buid configurations are made * Fix comment on MM VCR build * Update VCR post step to fail if no cassettes are produced by the tests before * Whitespace changes * Fix how teamcity files are copied to the downstreams * Change how VCR build configs are named * remove newlines * Fix defect in post VCR build steps * Refactor labelling that indicates automated vs ad hoc builds * Make VCR builds be triggered to indicate VCR_MODE * Add first version of TeamCity documentation! * Add contents section to PERFORMING_TASKS_IN_TEAMCITY.md * Move details about DSL into technical README, away from process doc * Make the .teamcity folder only propogate to the TPG repo, and no longer be in the TPGB repo * Ensure all TeamCity files are being copied to the downstream repo * Move echo command to after `BRANCH_NAME` ENV declared * Update VCR steps to look for fixtures files inside beta folder * Update mmv1/third_party/terraform/.teamcity/components/builds/vcr_build_steps.kt Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/.teamcity/CONTRIBUTION_GUIDE.md Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * [#15779] Add google_network_security_firewall_endpoint resource (GoogleCloudPlatform#9813) * [#15779] Add google_network_security_firewall_endpoint resource * Fix yaml linting * Removing unused fields from yaml * Fixing tests * Fixes per comments --------- Co-authored-by: Luca Prete <[email protected]> * enhancement: Allow overriding the Billing Project for google_cloud_asset_resources_search_all (GoogleCloudPlatform#9935) * enhancement: Allow overriding the Billing Project for cloud_asset_resources_search_all * chore: Fixed indentation * Add firebaseappcheck to service package lists (GoogleCloudPlatform#9937) * Enable CRONs in TeamCity (GoogleCloudPlatform#9938) * Set CRONs for 4am UTC * Enable CRONs * Update enrolled_teams.yml (GoogleCloudPlatform#9939) * add NickElliot to vacation reviewers (GoogleCloudPlatform#9942) * Update membership.go * Update membership.go * fix lint issues * fix conversion compilation * Remove Runtime example * Add back kms flatten * change encryption to CMEK to test for KMS * Try using a global KMS key * kms key location to us-central1 * remove service account in full example * Adding back service account into full test --------- Co-authored-by: Iris Chen <[email protected]> Co-authored-by: hao-nan-li <[email protected]> Co-authored-by: Sarah French <[email protected]> Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Koen van Zuijlen <[email protected]> Co-authored-by: Ryan Oaks <[email protected]> Co-authored-by: Nick Elliot <[email protected]>
…leCloudPlatform#9813) * [#15779] Add google_network_security_firewall_endpoint resource * Fix yaml linting * Removing unused fields from yaml * Fixing tests * Fixes per comments --------- Co-authored-by: Luca Prete <[email protected]>
* add labels to runtime update test * Add desired_state for workbench instances * fix(tgc): Fixing the if block for existingConverterAsset and add test case (GoogleCloudPlatform#9914) * Add sweepers for vertex_dataset, vertex_tensorboard and vertex_metadataStore (GoogleCloudPlatform#9911) * Make acctest use bootstrapped KMS key, instead of making new key that resembles a shared key (GoogleCloudPlatform#9926) * Refactor the TeamCity config to define all projects, across GA, Beta, and VCR testing (GoogleCloudPlatform#9837) * Replace contents of .teamcity/ with new refactored config files * Remove remaining automation for generating service lists automatically * Remove copyright headers, as they're added during generation process * Update header comments on .teamcity files * Make VCR testing compatible with TeamCity agent * Update GA + Beta service lists to match the currrent provider * Fix whitespace * Update default TEST ENV value for VCR builds * Add chmod commands to handling of creds file * Update pre- and post-VCR steps to echo out more information about their actions * Rename `generated` folder to `inputs` * Update header comments on .teamcity files * Refactor how VCR recording buid configurations are made * Fix comment on MM VCR build * Update VCR post step to fail if no cassettes are produced by the tests before * Whitespace changes * Fix how teamcity files are copied to the downstreams * Change how VCR build configs are named * remove newlines * Fix defect in post VCR build steps * Refactor labelling that indicates automated vs ad hoc builds * Make VCR builds be triggered to indicate VCR_MODE * Add first version of TeamCity documentation! * Add contents section to PERFORMING_TASKS_IN_TEAMCITY.md * Move details about DSL into technical README, away from process doc * Make the .teamcity folder only propogate to the TPG repo, and no longer be in the TPGB repo * Ensure all TeamCity files are being copied to the downstream repo * Move echo command to after `BRANCH_NAME` ENV declared * Update VCR steps to look for fixtures files inside beta folder * Update mmv1/third_party/terraform/.teamcity/components/builds/vcr_build_steps.kt Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/.teamcity/CONTRIBUTION_GUIDE.md Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * [#15779] Add google_network_security_firewall_endpoint resource (GoogleCloudPlatform#9813) * [#15779] Add google_network_security_firewall_endpoint resource * Fix yaml linting * Removing unused fields from yaml * Fixing tests * Fixes per comments --------- Co-authored-by: Luca Prete <[email protected]> * enhancement: Allow overriding the Billing Project for google_cloud_asset_resources_search_all (GoogleCloudPlatform#9935) * enhancement: Allow overriding the Billing Project for cloud_asset_resources_search_all * chore: Fixed indentation * Add firebaseappcheck to service package lists (GoogleCloudPlatform#9937) * Enable CRONs in TeamCity (GoogleCloudPlatform#9938) * Set CRONs for 4am UTC * Enable CRONs * Update enrolled_teams.yml (GoogleCloudPlatform#9939) * add NickElliot to vacation reviewers (GoogleCloudPlatform#9942) * Update membership.go * Update membership.go * fix lint issues * fix conversion compilation * Remove Runtime example * Add back kms flatten * change encryption to CMEK to test for KMS * Try using a global KMS key * kms key location to us-central1 * remove service account in full example * Adding back service account into full test --------- Co-authored-by: Iris Chen <[email protected]> Co-authored-by: hao-nan-li <[email protected]> Co-authored-by: Sarah French <[email protected]> Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Luca Prete <[email protected]> Co-authored-by: Koen van Zuijlen <[email protected]> Co-authored-by: Ryan Oaks <[email protected]> Co-authored-by: Nick Elliot <[email protected]>
Adds the new
google_network_security_firewall_endpoint
resource.fixes hashicorp/terraform-provider-google/issues/15779
Release Note Template for Downstream PRs (will be copied)