Add creation_timestamp to google_compute_(region_)instance_group_manager #9874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I am a robot. It looks like you are a: Community Contributor @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
awaiting-approval
Tests analyticsTotal tests: Click here to see the affected service packages
|
shuyama1
reviewed
Jan 24, 2024
mmv1/third_party/terraform/services/compute/resource_compute_instance_group_manager.go.erb
Outdated
Show resolved
Hide resolved
...third_party/terraform/services/compute/resource_compute_region_instance_group_manager.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/compute/resource_compute_instance_group_manager.go.erb
Outdated
Show resolved
Hide resolved
...third_party/terraform/services/compute/resource_compute_region_instance_group_manager.go.erb
Outdated
Show resolved
Hide resolved
…nstance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]>
…egion_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]>
…nstance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]>
…egion_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]>
|
They definitely make sense, thank you! |
modular-magician
added
the
awaiting-approval
shuyama1
reviewed
Jan 25, 2024
mmv1/third_party/terraform/services/compute/resource_compute_instance_group_manager.go.erb
Outdated
Show resolved
Hide resolved
…nstance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]>
modular-magician
added
service/compute-managed
and removed
awaiting-approval
Tests analyticsTotal tests: Click here to see the affected service packages
|
shuyama1
approved these changes
Jan 25, 2024
This was referenced Jan 25, 2024
tdbhacks
pushed a commit
to tdbhacks/magic-modules
that referenced
this pull request
Feb 6, 2024
…ger (GoogleCloudPlatform#9874) * Add creation_timestamp to google_compute_(region_)instance_group_manager * Update mmv1/third_party/terraform/services/compute/resource_compute_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/services/compute/resource_compute_region_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/services/compute/resource_compute_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/services/compute/resource_compute_region_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/services/compute/resource_compute_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> --------- Co-authored-by: Shuya Ma <[email protected]>
balanaguharsha
pushed a commit
to balanaguharsha/magic-modules
that referenced
this pull request
Apr 19, 2024
…ger (GoogleCloudPlatform#9874) * Add creation_timestamp to google_compute_(region_)instance_group_manager * Update mmv1/third_party/terraform/services/compute/resource_compute_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/services/compute/resource_compute_region_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/services/compute/resource_compute_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/services/compute/resource_compute_region_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/services/compute/resource_compute_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> --------- Co-authored-by: Shuya Ma <[email protected]>
balanaguharsha
pushed a commit
to balanaguharsha/magic-modules
that referenced
this pull request
May 2, 2024
…ger (GoogleCloudPlatform#9874) * Add creation_timestamp to google_compute_(region_)instance_group_manager * Update mmv1/third_party/terraform/services/compute/resource_compute_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/services/compute/resource_compute_region_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/services/compute/resource_compute_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/services/compute/resource_compute_region_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/services/compute/resource_compute_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> --------- Co-authored-by: Shuya Ma <[email protected]>
pengq-google
pushed a commit
to pengq-google/magic-modules
that referenced
this pull request
May 21, 2024
…ger (GoogleCloudPlatform#9874) * Add creation_timestamp to google_compute_(region_)instance_group_manager * Update mmv1/third_party/terraform/services/compute/resource_compute_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/services/compute/resource_compute_region_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/services/compute/resource_compute_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/services/compute/resource_compute_region_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> * Update mmv1/third_party/terraform/services/compute/resource_compute_instance_group_manager.go.erb Co-authored-by: Shuya Ma <[email protected]> --------- Co-authored-by: Shuya Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add read-only creation_timestamp to google_compute_instance_group_manager and google_compute_region_instance_group_manager.
Solves (R)IGM part of hashicorp/terraform-provider-google#15663
Release Note Template for Downstream PRs (will be copied)