Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INITIAL DRAFT FOR FEEDBACK: Implement provider functions #9990

Closed
wants to merge 11 commits into from
Closed

INITIAL DRAFT FOR FEEDBACK: Implement provider functions #9990

wants to merge 11 commits into from

Commits on Feb 15, 2024

  1. Update go.mod and go.sum to support provider function feature 

    go get github.com/hashicorp/[email protected]
go get github.com/hashicorp/[email protected]
go get github.com/hashicorp/terraform-plugin-sdk/[email protected]
go mod tidy
    @SarahFrench
    SarahFrench committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    51228dd View commit details
    Browse the repository at this point in the history

  2. Add implementations of project_id_from_self_link and `resource_name… 

    …_from_self_link`, acceptance tests and unit tests for shared logic
    @SarahFrench
    SarahFrench committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    0ed07c7 View commit details
    Browse the repository at this point in the history

  3. Rename functions to use "id" over "self_link"

    @SarahFrench
    SarahFrench committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    3af986d View commit details
    Browse the repository at this point in the history

  4. Fix parts of reusable logic that mention projects specifically

    @SarahFrench
    SarahFrench committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    bed3154 View commit details
    Browse the repository at this point in the history

  5. Add region_from_id function

    @SarahFrench
    SarahFrench committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    515cb42 View commit details
    Browse the repository at this point in the history

  6. Standardise resource identifiers in acc tests

    @SarahFrench
    SarahFrench committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    09614e4 View commit details
    Browse the repository at this point in the history

  7. Add zone_from_id function

    @SarahFrench
    SarahFrench committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    d6ecf33 View commit details
    Browse the repository at this point in the history

  8. Rename function to name_from_id 

    Originally was `resource_name_from_self_link`
    @SarahFrench
    SarahFrench committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    c9575ed View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Rename function to project_from_id 

    Was previously `project_id_from_id`. This could be misleading if an input string contains a project number.
    @SarahFrench
    SarahFrench committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    91fe717 View commit details
    Browse the repository at this point in the history

  2. Add location_from_id function

    @SarahFrench
    SarahFrench committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    5d7e89e View commit details
    Browse the repository at this point in the history

  3. Unskip provider-defined function acceptance tests in VCR

    @SarahFrench
    SarahFrench committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    f0981a9 View commit details
    Browse the repository at this point in the history