Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable correct display of the service name in Cloud Trace #2349

Closed
minherz opened this issue Jan 23, 2024 · 1 comment
Closed

Enable correct display of the service name in Cloud Trace #2349

minherz opened this issue Jan 23, 2024 · 1 comment
Assignees
@minherz
Labels
area/kubernetes priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@minherz
Copy link
Contributor

minherz commented Jan 23, 2024 •
edited
Loading

Describe the bug

When capturing observability data to Cloud Ops suite is enabled (e.g. using the google-cloud-operations kustomize component, the Trace details grid in Cloud Trace does not correctly show most of the service names. Instead of the service name (e.g. "recommendationservice") it shows "unknown_service" or "unknown_service:server".

To Reproduce

  1. Deploy the app with the kustomize component "google-cloud-operations"
  2. Go to Cloud Trace and select any trace that corresponds to load-generated workflow
  3. See that except for the currencyservice and paymentservice (was fixed by Set OTEL service Name in node js services #2194 ) other service names are not displayed correctly
@minherz minherz self-assigned this Jan 23, 2024
@minherz minherz added area/kubernetes type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 23, 2024
@minherz minherz mentioned this issue Jan 23, 2024
Merged
@NimJay
Copy link
Collaborator

NimJay commented Jan 23, 2024 •
edited
Loading

@minherz fixed this in #2350. Closing.

@NimJay NimJay closed this as completed Jan 23, 2024
This was referenced Feb 2, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minherz minherz

Labels
area/kubernetes priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@minherz @NimJay