Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub action setup-dotnet@v3 in CIs #1120

Merged
merged 12 commits into from
Nov 29, 2022

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Sep 30, 2022

Update GitHub action setup-dotnet@v3 in CIs.

More information here about the removal of the parameter include-prerelease.

Fixing issue in #1117

@mathieu-benoit mathieu-benoit requested a review from a team as a code owner September 30, 2022 14:45
@mathieu-benoit
Copy link
Contributor Author

There is an issue while upgrading to v3: actions/setup-dotnet#327

@mathieu-benoit mathieu-benoit added the status: blocked Resolving the issue is dependent on other work. label Sep 30, 2022
@NimJay NimJay added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 3, 2022
@minherz
Copy link
Contributor

minherz commented Oct 10, 2022

@mathieu-benoit it looks like the current workflow does not support installing dotnet using new action's version. the test shows multiple "access denied" errors.

@bourgeoisor
Copy link
Member

bourgeoisor commented Oct 21, 2022

The Action has been updated to "fix this". Checks are still failing. The issue linked above has some hints that we may have to set the DOTNET_INSTALL_DIR env (actions/setup-dotnet#327 (comment))

@bourgeoisor bourgeoisor removed the status: blocked Resolving the issue is dependent on other work. label Oct 21, 2022
@NimJay NimJay added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 21, 2022
@NimJay NimJay added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Nov 22, 2022
@mathieu-benoit mathieu-benoit self-assigned this Nov 29, 2022
@mathieu-benoit
Copy link
Contributor Author

Still getting same error:

Error: Failed to install dotnet 1. dotnet-install: Note that the intended use of this script is for Continuous Integration (CI) scenarios, where:

Looking at actions/setup-dotnet#327 to see what we need to do.

@github-actions
Copy link

🚲 PR staged at http://34.173.34.194

@mathieu-benoit
Copy link
Contributor Author

Fixed! Ready for your review and merge, thanks!

@github-actions
Copy link

🚲 PR staged at http://34.173.34.194

Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bourgeoisor bourgeoisor merged commit e2e6ef2 into main Nov 29, 2022
@bourgeoisor bourgeoisor deleted the mathieu-benoit/setup-dotnet-v3 branch November 29, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants