fix: Upgrade to skaffold/v3 #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new runner with the skaffold V2 binary requires the runner to be rebuilt with the updated install-dependencies.sh see - https://github.com/GoogleCloudPlatform/microservices-demo/tree/main/.github/workflows#appendix---creating-a-new-actions-runner. |
|
First off, thank you, @mmcloud, for creating this pull-request! :) Do we also need to update https://github.com/mmcloud/microservices-demo/blob/skaffold-v2/docs/development-guide.md#prerequisites? |
|
I just upgrade the |
NimJay
reviewed
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Skaffold has released a major new update.
Fixes
Change Summary
Run
skaffold fixwith new skaffold v2.0.0 binarys.Additional Notes
For upgrade notes see:
https://skaffold.dev/docs/upgrading/
Testing Procedure
Related PRs or Issues