Helm chart - fix external dbs management and issues #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for your review, thanks! |
NimJay
reviewed
Dec 16, 2022
| @@ -32,37 +32,76 @@ jobs: | |||
| - name: helm lint | |||
| run: | | |||
| cd helm-chart/ | |||
| helm lint | |||
| helm lint --strict | |||
There was a problem hiding this comment.
Praise: This --strict flag ("fail on lint warnings") is a good idea!
NimJay
approved these changes
Dec 16, 2022
mathieu-benoit
deleted the
mathieu-benoit/fix-helm-chart-external-dbs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm chart - fix external dbs management and issues.
Related to these 2 e2e scenarios:
Adding more tests in CI to track such issues and potential future regressions.
Note: I have updated/pushed manually both Helm charts 0.4.2 and 0.5.0 to avoid any issue with the current Helm charts out there.