Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Workload Identity fix #1461

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Add documentation for Workload Identity fix #1461

merged 3 commits into from
Jan 24, 2023

Conversation

arbrown
Copy link
Contributor

@arbrown arbrown commented Jan 23, 2023

Background

Previously, workloads would use the default compute service account on GKE, which allowed them to use Google APIs by default. This changed for some versions of GKE Autopilot (and will change for Standard) and requires some extra work to allow the OTel collector to send traces to Cloud Trace.

Related PRs or Issues

#1444

Future Work

I think this is just a temporary fix until we get a better idea about how to handle these Workload Identity changes. Using the default service account is likely not an appropriate long-term solution, but works for now until we have a unified approach for handling service accounts and permissions in the project.

Previously, workloads would use the default compute service account on GKE, which allowed them to use Google APIs by default.  This changed for some versions of GKE Autopilot (and will change for Standard) and requires some extra work to allow the OTel collector to send traces to Cloud Trace.
@arbrown arbrown requested a review from a team as a code owner January 23, 2023 22:06
Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this solution, @arbrown (and for acknowledging that this is a temporary solution). I have made minor edits to the README.md in 498300b.

Manually Tested

I have tested the commands on my own GKE cluster (standard with workload identity enabled).
Tracing worked! 👍

Screenshot 2023-01-24 at 10 52 31 AM

Log Severity

All the logs output by by the opentelemetrycollector Pod have a severity of "ERROR" — even if the log itself is not an ERROR (e.g., in the screenshot below, I've expanded an INFO log).
Have you been experiencing the same?
If so, I can create a GitHub issue so we can track this issue.

Screenshot 2023-01-24 at 10 56 55 AM

@NimJay NimJay merged commit 6097f46 into main Jan 24, 2023
@NimJay NimJay deleted the wi-docs branch January 24, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants