Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 2> /dev/null in Terraform kubectl wait #1814

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Jun 2, 2023

Background

  • We added 2> /dev/null to the end of the kubectl wait command in our Terraform in when we added DeployStack support.
  • Purpose of 2> /dev/null: it silences standard errors logged by kubectl wait.
  • I think we only did this to make the DeployStack output cleaner.
  • But we should avoid silencing errors in general.

Change Summary

  • Unsilence kubectl wait errors.

Testing Procedure

  • No testing necessary as this is a trivial change.

Additional info

@NimJay NimJay requested a review from a team as a code owner June 2, 2023 14:44
@NimJay NimJay merged commit b3edd91 into main Jun 2, 2023
@NimJay NimJay deleted the nimjay-terraform-error-silencing branch June 2, 2023 15:05
sitaramkm pushed a commit to sitaramkm/microservices-demo that referenced this pull request Aug 24, 2023
mrcrgl pushed a commit to fiberfjord/microservices-demo that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants