cartservice - Memorystore (Redis) 7.0
#2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for your review, thanks! |
NimJay
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Thank you, @mathieu-benoit, for this update!
I was hoping to preserve the _x minor version (to prepare for when/if 7.1 is a thing), but it looks like redis_7_x isn't supported, based on docs here.
Looks great! Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memorstore (Redis) now supports Redis 7.0.
The in-cluster version of the
redis-carthas been using Redis 7.0 by default for a while now because of usingredis:alpine(i.e.latestbeing 7.0). So this is confirming thatcartserviceis working well with Redis 7.0, no issues.I also tested this as part of this "tutorial" (provisioning via
gcloud). I also did the test of provisioning a Memorystore (Redis) instance via Terraform. All good!