-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(renovate): move to per-language PR grouping, and weekly schedule. #2214
Conversation
🚲 PR staged at http://34.121.248.128 |
🚲 PR staged at http://34.121.248.128 |
1 similar comment
🚲 PR staged at http://34.121.248.128 |
], | ||
// Run once a week, outside typical office hours. | ||
// TZ is UTC unless specified. | ||
"schedule": [ "after 10pm on Tuesday" ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought: If you want to test the grouping logic ASAP, feel free to add this schedule
in a later PR. :)
(totally up to you, no action needed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scheduling affects the groupings - only changes found in a single "schedule interval" are considered for grouping, so longer schedule periods will help us get better grouping.
We can run renovate against the repo off-schedule whenever we'd like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change I think we should make is regarding approveMajorUpdates
. :)
Other than that, this looks awesome!
Thanks again so much, @muncus, for looking into our Renovate configs.
Your work here is really going to help our team.
Co-authored-by: Nim Jayawardena <[email protected]>
🚲 PR staged at http://34.121.248.128 |
🚲 PR staged at http://34.121.248.128 |
Renovate will group PRs by language, so we should receive one PR per week, per
language.
"language" also includes docker, so digest pinning should all be grouped in a
single PR as well.