Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(renovate): move to per-language PR grouping, and weekly schedule. #2214

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

muncus
Copy link
Contributor

@muncus muncus commented Oct 17, 2023

Renovate will group PRs by language, so we should receive one PR per week, per
language.

"language" also includes docker, so digest pinning should all be grouped in a
single PR as well.

@muncus muncus requested a review from minherz October 17, 2023 17:02
@github-actions
Copy link

🚲 PR staged at http://34.121.248.128

.github/renovate.json5 Outdated Show resolved Hide resolved
@github-actions
Copy link

🚲 PR staged at http://34.121.248.128

1 similar comment
@github-actions
Copy link

🚲 PR staged at http://34.121.248.128

@muncus muncus marked this pull request as ready for review October 17, 2023 18:28
@muncus muncus requested review from yoshi-approver and a team as code owners October 17, 2023 18:28
.github/renovate.json5 Outdated Show resolved Hide resolved
],
// Run once a week, outside typical office hours.
// TZ is UTC unless specified.
"schedule": [ "after 10pm on Tuesday" ],
Copy link
Collaborator

@NimJay NimJay Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought: If you want to test the grouping logic ASAP, feel free to add this schedule in a later PR. :)
(totally up to you, no action needed)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scheduling affects the groupings - only changes found in a single "schedule interval" are considered for grouping, so longer schedule periods will help us get better grouping.
We can run renovate against the repo off-schedule whenever we'd like.

Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change I think we should make is regarding approveMajorUpdates. :)

Other than that, this looks awesome!
Thanks again so much, @muncus, for looking into our Renovate configs.
Your work here is really going to help our team.

Co-authored-by: Nim Jayawardena <[email protected]>
@github-actions
Copy link

🚲 PR staged at http://34.121.248.128

@github-actions
Copy link

🚲 PR staged at http://34.121.248.128

@muncus muncus merged commit a8a10c3 into main Oct 18, 2023
10 checks passed
@muncus muncus deleted the renovate-pt2 branch October 18, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants