Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line to "terraform apply" deletion_protection #2244

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Nov 2, 2023

Background

Change Summary

  • This pull-request updates:
    1. the instructions
    2. the DeployStack test

Testing these changes

  • I have manually triggered the DeployStack test to run against this branch (nimjay-deletion-protection). See Cloud Build logs here, or check the GitHub check success status below (for the Test-Procedure (ds-tester-microservices-demo) GitHub check). Ping me if you need access to the Cloud Build logs.
Screenshot 2023-11-02 at 2 43 35 PM

@NimJay NimJay requested review from yoshi-approver and a team as code owners November 2, 2023 17:36
Copy link

github-actions bot commented Nov 2, 2023

🚲 PR staged at http://35.223.18.34

Copy link
Contributor

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. The new clean up process can be confusing. I recommend either to resolve the problem in the deployment process that will allow to remove delete_protection settings or to simplify the clean up process by advising to delete the cluster and accompanying resources, if any.

@NimJay NimJay merged commit 4dd5787 into main Nov 5, 2023
8 checks passed
@NimJay NimJay deleted the nimjay-deletion-protection branch November 5, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants