feat: add 'app' label to Deployment and Service objects #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚲 PR staged at http://35.188.43.51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When searching by the 'app' label, only pods would appear. To find the Service
or Deployment objects associated with the app, one would need to query by name.
In some cases (that is, 'frontend-external'), name is not sufficient.
Some tools, like the backstage.io kubernetes plugin, do not show the Deployment
and Service objects because they are missing these labels. This leads to
confusion about the service/deployment that owns the pods.
Change Summary
Adds the 'app' label to all Service and Deployment objects