Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change live demo domain to cymbal.dev #2329

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Change live demo domain to cymbal.dev #2329

merged 2 commits into from
Jan 11, 2024

Conversation

bourgeoisor
Copy link
Member

@bourgeoisor bourgeoisor commented Jan 10, 2024 •
edited
Loading

This PR changes the live demo URL from onlineboutique.dev to cymbal-shops.retail.cymbal.dev.

It also adds copyright headers on the release-cluster/ manifests.

@github-actions GitHub Actions
Copy link

🚲 PR staged at http://34.27.233.26

1 similar comment
@github-actions GitHub Actions
Copy link

🚲 PR staged at http://34.27.233.26

NimJay
NimJay approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks for doing this.
Waiting until tomorrow (as you suggested) before merging sounds good to me.

(And thanks for adding the license headers.)

@NimJay NimJay merged commit 43289ce into main Jan 11, 2024
10 checks passed
@NimJay NimJay deleted the issue-change-live-demo-domain branch January 11, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NimJay NimJay NimJay approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bourgeoisor @NimJay