Fix Stackdriver Logging errors #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
askmeegs
approved these changes
Sep 20, 2019
schachfeld
pushed a commit
to petscheit/microservices-demo
that referenced
this pull request
Jan 12, 2020
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stackdriver Logging was reporting certain logs as errors for some services. This fixes the issue (related: #101)
logger.propagate = Falseprevents the service from logging twice. The second log was appearing as an ERROR in Stackdriver Loggingloadgen.shwas sending logs to stderr, which was showing up as errors in Stackdriver. I redirected stderr to stdout, and now logs show up as INFO instead of ERROR. (The problem with this is real errors will also show up as INFO, but I think we'd prefer that to the current situation)