Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually set PROJECT_ID in push-deploy.yaml #2588

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Manually set PROJECT_ID in push-deploy.yaml #2588

merged 1 commit into from
Jun 14, 2024

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Jun 14, 2024 •
edited
Loading

  • See Google-internal bug: b/347294641
  • We've removed the GitHub Actions PROJECT_ID secret.

@NimJay NimJay requested review from yoshi-approver and a team as code owners June 14, 2024 19:44
@github-actions GitHub Actions
Copy link

🚲 PR staged at http://34.28.255.220

@NimJay NimJay merged commit e6a4bc1 into main Jun 14, 2024
7 checks passed
@NimJay NimJay deleted the NimJay-patch-1 branch June 14, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bourgeoisor bourgeoisor bourgeoisor approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NimJay @bourgeoisor