Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency rsa to v4.8 #775

Merged
merged 4 commits into from
May 6, 2022

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Mar 2, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rsa ==4.7 -> ==4.8 age adoption passing confidence

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team as a code owner March 2, 2022 18:55
@xtineskim xtineskim added do not merge Indicates a pull request not ready for merge, due to either quality or timing. python Pull requests that update Python code labels Mar 2, 2022
@xtineskim xtineskim removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 15, 2022
@NimJay
Copy link
Collaborator

NimJay commented Mar 28, 2022

requirements.txt was not updated.
I ticked the checkbox in the PR's description: "If you want to rebase/retry this PR, click this checkbox."
Renovate Bot's behaviour is inconsistent. In #765, the requirements.txt file was updated for one (of the two) microservices.

@NimJay NimJay added lang: python Issues specific to Python. and removed python Pull requests that update Python code labels Mar 30, 2022
@NimJay
Copy link
Collaborator

NimJay commented Apr 5, 2022

All requirements.txt files are now updated thanks to #780.

But the Github checks contain an error during the Docker-build of loadgenerator.
Namely, running:

pip install --prefix="/install" -r requirements.txt

results in:

ERROR: Could not find a version that satisfies the requirement charset-normalizer==2.0.10 (from versions: 0.1a0, 0.1.1a0, 0.1.2b0, 0.1.4b0, 0.1.5b0, 0.1.7, 0.1.8, 0.2.0, 0.2.1, 0.2.2, 0.2.3, 0.3.0, 1.0.0, 1.1.0, 1.1.1, 1.2.0, 1.3.0, 1.3.1, 1.3.2, 1.3.3, 1.3.4, 1.3.5, 1.3.6, 1.3.7, 1.3.8, 1.3.9, 1.4.0, 1.4.1, 2.0.0, 2.0.1, 2.0.2, 2.0.3, 2.0.4, 2.0.5, 2.0.6, 2.0.7, 2.0.8, 2.0.9)
ERROR: No matching distribution found for charset-normalizer==2.0.10
WARNING: You are using pip version 21.2.4; however, version 21.3.1 is available.

Same error in #765, #775 (this PR), and #794.

@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Apr 21, 2022

Was able to successfully test this PR in there: http://35.184.10.29, but there is still the update in this file src/emailservice/requirements.in missing.

@mathieu-benoit mathieu-benoit added the dependencies Pull requests that update a dependency file label Apr 21, 2022
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bourgeoisor bourgeoisor merged commit 704e033 into GoogleCloudPlatform:main May 6, 2022
@renovate-bot renovate-bot deleted the renovate/rsa-4.x branch May 6, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lang: python Issues specific to Python.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants