Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyyaml==6.0 as Direct Dependency #985

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Aug 31, 2022

Remove pyyaml==6.0 as Direct Dependency, fixing #713, so rollback of #711 since #979 has been merged into main.

To double check with @NimJay if it is what we need to do.

@mathieu-benoit mathieu-benoit requested a review from a team as a code owner August 31, 2022 02:50
@mathieu-benoit mathieu-benoit marked this pull request as draft August 31, 2022 02:50
@github-actions
Copy link

🚲 PR staged at http://34.135.62.121

@mathieu-benoit mathieu-benoit linked an issue Aug 31, 2022 that may be closed by this pull request
@mathieu-benoit mathieu-benoit marked this pull request as ready for review August 31, 2022 02:57
@mathieu-benoit
Copy link
Contributor Author

Ready for your review, thanks!

@mathieu-benoit mathieu-benoit added the lang: python Issues specific to Python. label Aug 31, 2022
Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks are passing. Looks good.
Thanks again, Mathieu!

@NimJay NimJay merged commit 9394e63 into main Aug 31, 2022
@NimJay NimJay deleted the mathieu-benoit/unpin-pyyaml-6-0 branch August 31, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang: python Issues specific to Python.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pyyaml==6.0 as Direct Dependency
2 participants