Skip to content

Commit

Permalink
feat!: drop node8 support (#30)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.
  • Loading branch information
alexander-fenster authored and Ace Nassri committed Nov 12, 2022
1 parent 1181bab commit 43d0fdc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions document-ai/test/batch_parse_form.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});

const storage = new Storage();
const bucketName = `nodejs-docs-samples-test-${uuid.v4()}`;
const cmd = `node batch_parse_form.js`;
const cmd = 'node batch_parse_form.js';

const testParseForm = {
projectId: process.env.GCLOUD_PROJECT,
location: 'us-central1',
gcsOutputUriPrefix: uuid.v4(),
};

describe(`Document AI batch parse form`, () => {
describe('Document AI batch parse form', () => {
before(async () => {
await storage.createBucket(bucketName);
});
Expand All @@ -43,7 +43,7 @@ describe(`Document AI batch parse form`, () => {
await bucket.delete();
});

it(`should parse the GCS invoice example as a form`, async () => {
it('should parse the GCS invoice example as a form', async () => {
const output = execSync(
`${cmd} ${testParseForm.projectId} ${testParseForm.location} gs://${bucketName}`
);
Expand Down
6 changes: 3 additions & 3 deletions document-ai/test/batch_parse_table.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});

const storage = new Storage();
const bucketName = `nodejs-docs-samples-test-${uuid.v4()}`;
const cmd = `node batch_parse_table.js`;
const cmd = 'node batch_parse_table.js';

const testParseTable = {
projectId: process.env.GCLOUD_PROJECT,
location: 'us-central1',
gcsOutputUriPrefix: uuid.v4(),
};

describe(`Document AI batch parse table`, () => {
describe('Document AI batch parse table', () => {
before(async () => {
await storage.createBucket(bucketName);
});
Expand All @@ -43,7 +43,7 @@ describe(`Document AI batch parse table`, () => {
await bucket.delete();
});

it(`should parse the GCS invoice example as as table`, async () => {
it('should parse the GCS invoice example as as table', async () => {
const output = execSync(
`${cmd} ${testParseTable.projectId} ${testParseTable.location} gs://${bucketName}`
);
Expand Down

0 comments on commit 43d0fdc

Please sign in to comment.