Apply eslint and prettier linter

GoogleCloudPlatform · Nov 14, 2018 · c1c3e5e · c1c3e5e
1 parent 48a8867
commit c1c3e5e
Show file tree

Hide file tree

Showing 14 changed files with 32 additions and 11 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -2,3 +2,4 @@
 appengine/loopback/*
 functions/**
 iot/*
+appengine/parse-server/cloud/main.js
diff --git a/appengine/building-an-app/update/package.json b/appengine/building-an-app/update/package.json
@@ -24,7 +24,6 @@
   },
   "devDependencies": {
     "@google-cloud/nodejs-repo-tools": "1.4.17",
-    "ava": "0.25.0",
-    "semistandard": "^12.0.1"
+    "ava": "0.25.0"
   }
 }
diff --git a/appengine/cloudsql/package.json b/appengine/cloudsql/package.json
@@ -29,7 +29,10 @@
   },
   "devDependencies": {
     "@google-cloud/nodejs-repo-tools": "^3.0.0",
-    "ava": "0.25.0"
+    "ava": "0.25.0",
+    "proxyquire": "^2.1.0",
+    "sinon": "^7.1.1",
+    "supertest": "^3.3.0"
   },
   "cloud-repo-tools": {
     "requiresKeyFile": true,

diff --git a/appengine/cloudsql_postgresql/package.json b/appengine/cloudsql_postgresql/package.json
@@ -29,7 +29,10 @@
   },
   "devDependencies": {
     "@google-cloud/nodejs-repo-tools": "^3.0.0",
-    "ava": "0.25.0"
+    "ava": "0.25.0",
+    "proxyquire": "^2.1.0",
+    "sinon": "^7.1.1",
+    "supertest": "^3.3.0"
   },
   "cloud-repo-tools": {
     "requiresKeyFile": true,

diff --git a/appengine/endpoints/package.json b/appengine/endpoints/package.json
@@ -28,6 +28,9 @@
   },
   "devDependencies": {
     "@google-cloud/nodejs-repo-tools": "^3.0.0",
-    "ava": "0.25.0"
+    "ava": "0.25.0",
+    "proxyquire": "^2.1.0",
+    "sinon": "^7.1.1",
+    "supertest": "^3.3.0"
   }
 }
diff --git a/appengine/errorreporting/app.js b/appengine/errorreporting/app.js
@@ -24,7 +24,7 @@ app.get('/', (req, res, next) => {
   next(new Error('something is wrong!'));
 });
 
-app.use((err, req, res, next) => {
+app.use((err, req, res) => {
   errors.report(err);
   res.status(500).send(err.message || 'Something broke!');
 });

diff --git a/appengine/errorreporting/package.json b/appengine/errorreporting/package.json
@@ -26,7 +26,8 @@
     "@google-cloud/nodejs-repo-tools": "^3.0.0",
     "ava": "0.25.0",
     "proxyquire": "2.0.0",
-    "sinon": "4.4.2"
+    "sinon": "4.4.2",
+    "supertest": "^3.3.0"
   },
   "cloud-repo-tools": {
     "test": {

diff --git a/appengine/storage/flexible/system-test/.eslintrc.yaml b/appengine/storage/flexible/system-test/.eslintrc.yaml
@@ -0,0 +1,3 @@
+---
+rules:
+  no-empty: off
diff --git a/appengine/storage/flexible/system-test/app.test.js b/appengine/storage/flexible/system-test/app.test.js
@@ -27,7 +27,7 @@ const requestObj = utils.getRequest({cwd: cwd});
 
 test.before(async () => {
   utils.checkCredentials();
-  await bucket.create(bucket).then(data => {
+  await bucket.create(bucket).then(() => {
     return bucket.acl.add({
       entity: 'allUsers',
       role: Storage.acl.READER_ROLE,

diff --git a/appengine/storage/standard/system-test/.eslintrc.yaml b/appengine/storage/standard/system-test/.eslintrc.yaml
@@ -0,0 +1,3 @@
+---
+rules:
+  no-empty: off
diff --git a/appengine/storage/standard/system-test/app.test.js b/appengine/storage/standard/system-test/app.test.js
@@ -27,7 +27,7 @@ const requestObj = utils.getRequest({cwd: cwd});
 
 test.before(async () => {
   utils.checkCredentials();
-  await bucket.create(bucket).then(data => {
+  await bucket.create(bucket).then(() => {
     return bucket.acl.add({
       entity: 'allUsers',
       role: Storage.acl.READER_ROLE,

diff --git a/appengine/system-test/all.test.js b/appengine/system-test/all.test.js
@@ -26,7 +26,7 @@ var sampleTests = [
     msg: 'Hello World! Express.js + Grunt.js on Google App Engine.',
     TRAVIS_NODE_VERSION: '0.12',
   },
-  // TODO: Investigate flaky test
+  // Investigate flaky test
   // {
   //   dir: 'appengine/loopback',
   //   cmd: 'node',

diff --git a/appengine/twilio/app.js b/appengine/twilio/app.js
@@ -28,7 +28,9 @@ if (!TWILIO_NUMBER) {
   console.log(
     'Please configure environment variables as described in README.md'
   );
-  process.exit(1);
+  throw new Error(
+    'Please configure environment variables as described in README.md'
+  );
 }
 
 const twilio = require('twilio')(

diff --git a/appengine/uglifyjs/static/.eslintrc.yaml b/appengine/uglifyjs/static/.eslintrc.yaml
@@ -0,0 +1,3 @@
+---
+env: 
+  browser: true