Address comments.

GoogleCloudPlatform · Sep 27, 2016 · eae0a6f · eae0a6f
1 parent f74c020
commit eae0a6f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/pubsub/subscriptions.js b/pubsub/subscriptions.js
@@ -135,7 +135,7 @@ function getSubscriptionMetadata (subscriptionName, callback) {
 
     console.log(`Subscription: ${metadata.name}`);
     console.log(`Topic: ${metadata.topic}`);
-    console.log(`Push config: %s`, metadata.pushConfig.pushEndpoint);
+    console.log(`Push config: ${metadata.pushConfig.pushEndpoint}`);
     console.log(`Ack deadline: ${metadata.ackDeadlineSeconds}s`);
     callback();
   });
@@ -158,7 +158,7 @@ function pullMessages (subscriptionName, callback) {
     console.log(`Received ${messages.length} messages.`);
 
     messages.forEach((message) => {
-      console.log(`* ${message.id} %j %j`, message.data, message.attributes);
+      console.log(`* %d %j %j`, message.id, message.data, message.attributes);
     });
 
     // Acknowledges received messages. If you do not acknowledge, Pub/Sub will

diff --git a/pubsub/system-test/subscriptions.test.js b/pubsub/system-test/subscriptions.test.js
@@ -39,9 +39,12 @@ describe(`pubsub:subscriptions`, () => {
   after((done) => {
     pubsub.subscription(subscriptionNameOne).delete(() => {
       // Ignore any error
-      pubsub.topic(topicName).delete(() => {
+      pubsub.subscription(subscriptionNameTwo).delete(() => {
         // Ignore any error
-        done();
+        pubsub.topic(topicName).delete(() => {
+          // Ignore any error
+          done();
+        });
       });
     });
   });
@@ -81,6 +84,7 @@ describe(`pubsub:subscriptions`, () => {
       const output = run(`${cmd} list`, cwd);
       assert.notEqual(output.indexOf(`Subscriptions:`), -1);
       assert.notEqual(output.indexOf(fullSubscriptionNameOne), -1);
+      assert.notEqual(output.indexOf(fullSubscriptionNameTwo), -1);
       done();
     }, 5000);
   });
@@ -90,6 +94,7 @@ describe(`pubsub:subscriptions`, () => {
     const output = run(`${cmd} list ${topicName}`, cwd);
     assert.notEqual(output.indexOf(`Subscriptions for ${topicName}:`), -1);
     assert.notEqual(output.indexOf(fullSubscriptionNameOne), -1);
+    assert.notEqual(output.indexOf(fullSubscriptionNameTwo), -1);
     done();
   });