Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README "How to run a sample" Contains Incorrect Instructions #1358

Closed
grant opened this issue Jun 11, 2019 · 0 comments · Fixed by #1404
Closed

README "How to run a sample" Contains Incorrect Instructions #1358

grant opened this issue Jun 11, 2019 · 0 comments · Fixed by #1404
Assignees
@fhinkel

Comments

@grant
Copy link
Contributor

grant commented Jun 11, 2019 •
edited
Loading

The README states how to run a sample:

https://github.com/GoogleCloudPlatform/nodejs-docs-samples#how-to-run-a-sample

It requires you to cd into bigquery.

But there is no bigquery folder.

Looks like it was broken in this PR: #535

Discovered this bug looking at b/64476727
@jmdobry jmdobry assigned fhinkel and unassigned jmdobry Jun 11, 2019
@grant grant changed the title README "How to run a sample" Completely Wrong README "How to run a sample" Contains Incorrect Instructions Jun 25, 2019
fhinkel added a commit that referenced this issue Jul 10, 2019
@fhinkel
Update README.md
792a4f1 
Fixes #1358
@fhinkel fhinkel mentioned this issue Jul 10, 2019
Merged
fhinkel added a commit that referenced this issue Jul 11, 2019
@fhinkel
Update README.md (#1404)
ebedc44 
Fixes #1358
This was referenced Jun 20, 2023
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fhinkel fhinkel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update README.md GoogleCloudPlatform/nodejs-docs-samples
3 participants
@fhinkel @grant @jmdobry