Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eventarc: generic #1989

Closed
grant opened this issue Sep 30, 2020 · 0 comments · Fixed by #2003
Closed

eventarc: generic #1989

grant opened this issue Sep 30, 2020 · 0 comments · Fixed by #2003
Assignees
@grant
Labels
api: eventarc Issues related to the Eventarc API. samples Issues that are directly related to samples. type: docs Improvement to the documentation for an API.

Comments

@grant
Copy link
Contributor

grant commented Sep 30, 2020

Note to self to add a generic sample that logs the HTTP request for an event receiver:

https://github.com/gcpevents/eventsforcloudrun/blob/master/node/index.js
@grant grant self-assigned this Sep 30, 2020
@product-auto-label product-auto-label bot added api: eventarc Issues related to the Eventarc API. samples Issues that are directly related to samples. labels Sep 30, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Oct 1, 2020
@sofisl sofisl added the type: docs Improvement to the documentation for an API. label Oct 5, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Oct 5, 2020
@grant grant mentioned this issue Oct 10, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 12, 2020
@grant
feat: add eventarc generic sample (#2003)
68c1449 
- Adds a generic Eventarc sample
  - Re-uses same setup as other Eventarc samples
  - Logs and returns request headers and body. Deletes auth header (if present).
  - Tests that: headers and body are logged except auth header
- Tested locally

Fixes #1989
This was referenced Jan 11, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 20, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grant grant

Labels
api: eventarc Issues related to the Eventarc API. samples Issues that are directly related to samples. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add eventarc generic sample GoogleCloudPlatform/nodejs-docs-samples
3 participants
@grant @yoshi-automation @sofisl