Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markDone() needs to set the 'done' property to true #77

Closed
WalterHub opened this issue Mar 5, 2016 · 1 comment
Closed

markDone() needs to set the 'done' property to true #77

WalterHub opened this issue Mar 5, 2016 · 1 comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@WalterHub
Copy link
Contributor

https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/master/datastore/tasks.js#L116 needs true instead of false.
@jmdobry
Copy link
Member

jmdobry commented Mar 5, 2016

Fixed by 52ed71

@jmdobry jmdobry closed this as completed Mar 5, 2016
@jmdobry jmdobry added the bug label Mar 5, 2016
sethbergman pushed a commit to stackriot/nodejs-docs-samples that referenced this issue Jun 4, 2017
Fix hasMore not fetching datastore cursor (GoogleCloudPlatform#77)
bec07f3 
* Fix hasMore not fetching datastore cursor

* Remove magic string + use separate datastore library

* Fix optional-gce
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
telpirion pushed a commit that referenced this issue Nov 9, 2022
@yoshi-automation @JustinBeckwith
chore: release 1.2.0 (#77)
9fbabb7 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
@telpirion telpirion mentioned this issue Nov 9, 2022
Merged
telpirion pushed a commit that referenced this issue Nov 9, 2022
@yoshi-automation @telpirion
chore: release 1.2.0 (#77)
9c06e14 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
ace-n pushed a commit that referenced this issue Nov 14, 2022
@alexander-fenster
test: make samples tests pass (#77)
c17e035 
* chore: do not run samples test task

* make samples tests work

* circleci config

* making vms_api sample test work

* make lint pass for samples
This was referenced Nov 14, 2022
Closed
Merged
NimJay pushed a commit that referenced this issue Nov 18, 2022
@renovate-bot @alexander-fenster
chore(deps): update dependency execa to v4 (#77)
eccc3b1
@NimJay NimJay mentioned this issue Nov 18, 2022
Merged
NimJay pushed a commit that referenced this issue Nov 18, 2022
@renovate-bot @NimJay
chore(deps): update dependency execa to v4 (#77)
54ba25c
ace-n pushed a commit that referenced this issue Nov 21, 2022
@alexander-fenster
test: make samples tests pass (#77)
5940b04 
* chore: do not run samples test task

* make samples tests work

* circleci config

* making vms_api sample test work

* make lint pass for samples
ace-n pushed a commit that referenced this issue Nov 21, 2022
@alexander-fenster
test: make samples tests pass (#77)
13981ad 
* chore: do not run samples test task

* make samples tests work

* circleci config

* making vms_api sample test work

* make lint pass for samples
jsimonweb pushed a commit to jsimonweb/nodejs-docs-samples that referenced this issue Dec 12, 2022
@renovate-bot
chore(deps): update googlecloudplatform/release-please-action action …
f630296 
…to v3.2.9 (GoogleCloudPlatform#77)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WalterHub @jmdobry @yoshi-automation