Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jobs sample #878

Closed
11 tasks
fhinkel opened this issue Nov 11, 2018 · 0 comments
Closed
11 tasks

Update jobs sample #878

fhinkel opened this issue Nov 11, 2018 · 0 comments
Assignees
@fhinkel

Comments

@fhinkel
Copy link
Contributor

fhinkel commented Nov 11, 2018 •
edited
Loading

Current state of Jobs sample

  • Readme lacks info about which API to enable
  • Links in Readme go to ../Readme.md, but the parent folder doesn't contain any files.
  • There is only one folder, cjd in jobs, delete the extra layer
  • Dependencies include yargs, uuid, and safe-buffer, all unused
  • DevDependecies include unused dependencies like proxyquire
  • Linting should be update to eslint
  • The sample should be renamed to Cloud Talent Solution
  • Sample needs to be updated to v3
  • Update Node version in sample
  • Update googleapis, currently on 27
  • Use current auth

Here's the documentation for v2.
@fhinkel fhinkel self-assigned this Nov 11, 2018
fhinkel added a commit that referenced this issue Nov 12, 2018
@fhinkel
Update jobs sample
e812a78 
Update googleapis, use current auth.

Refs: #878
@fhinkel fhinkel mentioned this issue Nov 12, 2018
Merged
fhinkel added a commit that referenced this issue Nov 12, 2018
@fhinkel
Update jobs sample
02f444a 
Update googleapis, use current auth.

Refs: #878
fhinkel added a commit that referenced this issue Nov 12, 2018
@fhinkel
Update jobs sample (#880)
8cfa75b 
Update googleapis, use current auth.

Refs: #878
@fhinkel fhinkel added the Fixit label Nov 14, 2018
@fhinkel fhinkel closed this as completed Dec 17, 2018
This was referenced Oct 7, 2020
Open
Open
Open
Open
@ninadhatkar ninadhatkar mentioned this issue Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fhinkel fhinkel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fhinkel @jmdobry