Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(functions/helloworld):ava to mocha #1232

Merged
merged 2 commits into from
Apr 4, 2019
Merged

refactor(functions/helloworld):ava to mocha #1232

merged 2 commits into from
Apr 4, 2019

Conversation

AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Apr 2, 2019 •
edited
Loading

Towards #1080

refactor functions/helloworld ava to mocha

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 2, 2019
@AVaksman AVaksman added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 2, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 2, 2019
@AVaksman AVaksman marked this pull request as ready for review April 2, 2019 19:33
@AVaksman AVaksman changed the title refactor(function/helloworld):ava to mocha refactor(functions/helloworld):ava to mocha Apr 2, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 3, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 3, 2019
@AVaksman AVaksman added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 3, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 3, 2019
@fhinkel fhinkel merged commit 593a350 into GoogleCloudPlatform:master Apr 4, 2019
ace-n pushed a commit that referenced this pull request Jun 10, 2019
Revert changes to helloHttp (customer feedback)
2b4a848 
Changes were made in #1232; this reverts them.
@ace-n ace-n mentioned this pull request Jun 10, 2019
Merged
fhinkel pushed a commit that referenced this pull request Jun 10, 2019
@fhinkel
Revert changes to helloHttp (customer feedback) (#1352)
c7aeee3 
Changes were made in #1232; this reverts them.
@leejh3224 leejh3224 mentioned this pull request Jul 6, 2023
Open
@pedroarapua pedroarapua mentioned this pull request Jul 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AVaksman @fhinkel @googlebot @kokoro-team