Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @google-cloud/text-to-speech to v1 #1286

Merged
merged 3 commits into from
Aug 1, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 14, 2019

This PR contains the following updates:

Package Type Update Change References
@​google-cloud/text-to-speech dependencies major ^0.5.0 -> ^1.0.0 source

Release Notes

googleapis/nodejs-text-to-speech

v1.0.0

Compare Source

Bug Fixes
  • deps: update dependency google-gax to v1 (#​223) (aa8bbed)
  • DEADLINE_EXCEEDED is idempotent (#​224) (affbbd1)
  • DEADLINE_EXCEEDED no longer treated as idempotent and retried (9e5baee)
  • deps: update dependency google-gax to ^0.26.0 (#​212) (30ea99f)
Build System
BREAKING CHANGES
  • upgrade engines field to >=8.10.0 (#​214)

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 14, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 15, 2019
@fhinkel
Copy link
Contributor

fhinkel commented May 15, 2019

This dependency uses grpc 1.20, which doesn't work with Node 6

> [email protected] pretest /tmpfs/src/github/nodejs-docs-samples/functions/speech-to-speech/functions
> sh test/updateFunctions.sh
ERROR: Function load error: Code could not be loaded.
ERROR: Does the file exists? Is there a syntax error in your code?
ERROR: Detailed stack trace: Warning, estimating Firebase Config based on GCLOUD_PROJECT. Initializing firebase-admin may fail
/tmpfs/src/github/nodejs-docs-samples/functions/speech-to-speech/functions/node_modules/@google-cloud/text-to-speech/node_modules/@grpc/grpc-js/build/src/index.js:45
    throw new Error(`@grpc/grpc-js only works on Node ${supportedNodeVersions}`);
    ^
Error: @grpc/grpc-js only works on Node ^8.13.0 || >=10.10.0
    at Object.<anonymous> (/tmpfs/src/github/nodejs-docs-samples/functions/speech-to-speech/functions/node_modules/@google-cloud/text-to-speech/node_modules/@grpc/grpc-js/build/src/index.js:45:11)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/tmpfs/src/github/nodejs-docs-samples/functions/speech-to-speech/functions/node_modules/@google-cloud/text-to-speech/node_modules/google-gax/build/src/grpc.js:37:14)
    at Module._compile (module.js:653:30)
ERROR: Error: Failed to deploy function.
    at exec (/tmpfs/src/github/nodejs-docs-samples/functions/speech-to-speech/functions/node_modules/@google-cloud/functions-emulator/src/cli/controller.js:126:22)
    at ChildProcess.exithandler (child_process.js:283:5)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at maybeClose (internal/child_process.js:915:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)

@fhinkel
Copy link
Contributor

fhinkel commented May 15, 2019

Assigning to @ace-n as it's in functions.

@renovate renovate bot force-pushed the renovate/google-cloud-text-to-speech-1.x branch 2 times, most recently from 9e89d75 to 5b09f88 Compare May 15, 2019 18:53
@renovate renovate bot force-pushed the renovate/google-cloud-text-to-speech-1.x branch from 5b09f88 to ae129b0 Compare May 15, 2019 19:29
@ace-n
Copy link
Contributor

ace-n commented May 15, 2019

I think @stew-r (GCF PM) had some objections to killing off our Node 6 samples. (Personally I don't mind, but we're not deprecating disabling the Node 6 runtime until 2020.)

@stew-r
Copy link
Contributor

stew-r commented May 15, 2019

Let's not delete samples specific to Cloud Functions until we decommission the runtime.

@renovate
Copy link
Contributor Author

renovate bot commented May 17, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 20, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 20, 2019
This was referenced Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants