Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system test checker #1327

Merged
merged 2 commits into from
May 31, 2019
Merged

Add system test checker #1327

merged 2 commits into from
May 31, 2019

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented May 31, 2019

Note: I didn't fix any of the errors thrown by this script (they're mostly in the functions directory).

@fhinkel let me know if I should fix those in this PR or a separate one. My thoughts:

  1. Merge this
  2. Merge PR fixing this (or at least adding kokoro-allow-mock comments - though I can do that in this PR too)
  3. Add to CI

@ace-n ace-n requested a review from fhinkel May 31, 2019 01:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 31, 2019
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate PRs is fine for me.

@ace-n ace-n merged commit f57ff0d into master May 31, 2019
@ace-n ace-n deleted the system-tests branch May 31, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants