Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datastore sample: functions/datastore -> datastore/functions #1460

Merged
merged 3 commits into from
Aug 30, 2019

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Aug 29, 2019

@JustinBeckwith @crwilcox as FYI, since we'll be re-creating the datastore directory that was obviated by the nodejs-datastore repo.

@ace-n ace-n requested a review from grant August 29, 2019 20:27
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 29, 2019
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing functions/README.md change.

@ace-n ace-n changed the title Remove unused datastore sample Datastore sample: functions/datastore -> datastore/functions Aug 29, 2019
@ace-n ace-n requested a review from fhinkel as a code owner August 29, 2019 21:31
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ace-n pushed a commit that referenced this pull request Aug 29, 2019
RE `datastore/functions` - see #1460
@ace-n ace-n merged commit 09d6d7c into master Aug 30, 2019
@ace-n ace-n deleted the delete-datastore branch August 30, 2019 20:06
ace-n pushed a commit that referenced this pull request Aug 30, 2019
This was referenced Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants