-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaces outdated instructions that reference the Functions emulator. #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Functions Framework requires Node.js version 10 or higher. This commit updates the version of node in the `.nvmrc` file to **lts/Dubnium**, which corresponds to version `10.13.0` at this time.
Replaces the instructions to use the (deprecated) Functions emulator with instructions on how to use the Functions Framework instead.
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Oct 3, 2019
ricalo
changed the title
Replaces outdated README that references the Functions emulator.
Replaces outdated instructions that reference the Functions emulator.
Oct 3, 2019
Requesting review from @ace-n for accuracy. Note: There are two failing tests. However, it doesn't look like the errors are related to this PR. Let me know if there's anything to fix on my end. |
fhinkel
approved these changes
Oct 4, 2019
kokoro-team
removed
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Oct 4, 2019
kokoro-team
removed
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Oct 7, 2019
ping @ace-n |
ace-n
approved these changes
Oct 7, 2019
This was referenced Dec 23, 2020
This was referenced Jul 31, 2022
This was referenced Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates README of the speech-to-speech sample with instructions that use the Functions Framework instead of the Functions emulator.
The speech-to-speech sample was updated to replace the Functions emulator in #1255.
This fixes #1500.