Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces outdated instructions that reference the Functions emulator. #1502

Merged
merged 6 commits into from
Oct 8, 2019
Merged

Conversation

ricalo
Copy link
Member

@ricalo ricalo commented Oct 3, 2019

Updates README of the speech-to-speech sample with instructions that use the Functions Framework instead of the Functions emulator.

The speech-to-speech sample was updated to replace the Functions emulator in #1255.

This fixes #1500.

The Functions Framework requires Node.js version 10 or higher. This commit
updates the version of node in the `.nvmrc` file to **lts/Dubnium**, which
corresponds to version `10.13.0` at this time.
Replaces the instructions to use the (deprecated) Functions emulator with
instructions on how to use the Functions Framework instead.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2019
@ricalo ricalo changed the title Replaces outdated README that references the Functions emulator. Replaces outdated instructions that reference the Functions emulator. Oct 3, 2019
@ricalo ricalo requested a review from ace-n October 3, 2019 17:32
@ricalo
Copy link
Member Author

ricalo commented Oct 3, 2019

Requesting review from @ace-n for accuracy.

Note: There are two failing tests. However, it doesn't look like the errors are related to this PR. Let me know if there's anything to fix on my end.

@ricalo ricalo requested a review from fhinkel October 3, 2019 17:35
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 4, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 4, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 7, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 7, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Oct 7, 2019

ping @ace-n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speech to speech Readme is outdated
5 participants