-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud client library migration part 1: Registry management #1558
Conversation
FYI the tests are failing outside of this change. |
@hongalex PTAL, updated the logging as appropriate and addressed nits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I wanted to print all the errors with console.error
instead. Marked the places that need to be updated.
I went ahead and cleaned up the whole file, there was inconsistent use of console error and log. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.