Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud client library migration part 1: Registry management #1558

Merged
merged 12 commits into from
Dec 10, 2019

Conversation

gguuss
Copy link
Contributor

@gguuss gguuss commented Dec 3, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 3, 2019
@gguuss gguuss requested a review from hongalex December 3, 2019 22:14
@gguuss
Copy link
Contributor Author

gguuss commented Dec 3, 2019

FYI the tests are failing outside of this change.

iot/manager/manager.js Outdated Show resolved Hide resolved
iot/manager/manager.js Outdated Show resolved Hide resolved
iot/manager/manager.js Outdated Show resolved Hide resolved
iot/manager/manager.js Outdated Show resolved Hide resolved
@gguuss gguuss closed this Dec 5, 2019
@gguuss gguuss reopened this Dec 5, 2019
@gguuss
Copy link
Contributor Author

gguuss commented Dec 5, 2019

@hongalex PTAL, updated the logging as appropriate and addressed nits.

Copy link
Contributor

@hongalex hongalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I wanted to print all the errors with console.error instead. Marked the places that need to be updated.

iot/manager/manager.js Outdated Show resolved Hide resolved
iot/manager/manager.js Outdated Show resolved Hide resolved
iot/manager/manager.js Outdated Show resolved Hide resolved
iot/manager/manager.js Outdated Show resolved Hide resolved
iot/manager/manager.js Outdated Show resolved Hide resolved
iot/manager/manager.js Outdated Show resolved Hide resolved
iot/manager/manager.js Outdated Show resolved Hide resolved
iot/manager/manager.js Outdated Show resolved Hide resolved
iot/manager/manager.js Outdated Show resolved Hide resolved
iot/manager/manager.js Outdated Show resolved Hide resolved
@gguuss
Copy link
Contributor Author

gguuss commented Dec 6, 2019

I went ahead and cleaned up the whole file, there was inconsistent use of console error and log.

@gguuss gguuss requested a review from hongalex December 9, 2019 18:49
Copy link
Contributor

@hongalex hongalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants