Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cloud run ga #1582

Merged
merged 3 commits into from
Jan 24, 2020
Merged

chore: cloud run ga #1582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16f779d
chore: cloud run ga
grant Jan 7, 2020
1f34d8c
Merge branch 'master' into grant_cloud_run_ga
grant Jan 9, 2020
1de1b1b
Merge branch 'master' into grant_cloud_run_ga
grant Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cloud-sql/mysql/mysql/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,15 +104,15 @@ gcloud builds submit --tag gcr.io/[YOUR_PROJECT_ID]/run-sql
2. Deploy the service to Cloud Run:

```sh
gcloud beta run deploy run-sql --image gcr.io/[YOUR_PROJECT_ID]/run-sql
gcloud run deploy run-sql --image gcr.io/[YOUR_PROJECT_ID]/run-sql
```

Take note of the URL output at the end of the deployment process.

3. Configure the service for use with Cloud Run

```sh
gcloud beta run services update run-sql \
gcloud run services update run-sql \
--add-cloudsql-instances [INSTANCE_CONNECTION_NAME] \
--set-env-vars CLOUD_SQL_CONNECTION_NAME=[INSTANCE_CONNECTION_NAME],\
DB_USER=[MY_DB_USER],DB_PASS=[MY_DB_PASS],DB_NAME=[MY_DB]
Expand Down
4 changes: 2 additions & 2 deletions cloud-sql/postgres/knex/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,15 @@ gcloud builds submit --tag gcr.io/[YOUR_PROJECT_ID]/run-sql
2. Deploy the service to Cloud Run:

```sh
gcloud beta run deploy run-sql --image gcr.io/[YOUR_PROJECT_ID]/run-sql
gcloud run deploy run-sql --image gcr.io/[YOUR_PROJECT_ID]/run-sql
```

Take note of the URL output at the end of the deployment process.

3. Configure the service for use with Cloud Run

```sh
gcloud beta run services update run-sql \
gcloud run services update run-sql \
--add-cloudsql-instances [INSTANCE_CONNECTION_NAME] \
--set-env-vars CLOUD_SQL_CONNECTION_NAME=[INSTANCE_CONNECTION_NAME],\
DB_USER=[MY_DB_USER],DB_PASS=[MY_DB_PASS],DB_NAME=[MY_DB]
Expand Down
2 changes: 1 addition & 1 deletion run/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ For more Cloud Run samples beyond Node.js, see the main list in the [Cloud Run S

```
gcloud builds submit --tag gcr.io/${GOOGLE_CLOUD_PROJECT}/${SAMPLE}
gcloud beta run deploy $SAMPLE \
gcloud run deploy $SAMPLE \
# Needed for Manual Logging sample.
--set-env-var GOOGLE_CLOUD_PROJECT=${GOOGLE_CLOUD_PROJECT} \
--image gcr.io/${GOOGLE_CLOUD_PROJECT}/${SAMPLE}
Expand Down
2 changes: 1 addition & 1 deletion run/hello-broken/test/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ requireEnv CONTAINER_IMAGE

# Deploy the service
set -x
gcloud beta run deploy "${SERVICE_NAME}" \
gcloud run deploy "${SERVICE_NAME}" \
--image="${CONTAINER_IMAGE}" \
--region="${REGION:-us-central1}" \
${FLAGS} \
Expand Down
4 changes: 2 additions & 2 deletions run/hello-broken/test/runner.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ echo
# Only needed if deploy completed.
function cleanup {
set -x
gcloud beta run services delete ${SERVICE_NAME} \
gcloud run services delete ${SERVICE_NAME} \
--platform=managed \
--region="${REGION:-us-central1}" \
--quiet
gcloud beta run services delete ${SERVICE_OVERRIDE} \
gcloud run services delete ${SERVICE_OVERRIDE} \
--platform=managed \
--region="${REGION:-us-central1}" \
--quiet
Expand Down
2 changes: 1 addition & 1 deletion run/hello-broken/test/url.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ requireEnv() {
requireEnv SERVICE_NAME

set -x
gcloud beta run services \
gcloud run services \
describe "${SERVICE_NAME}" \
--region="${REGION:-us-central1}" \
--format='value(status.domain)' \
Expand Down
2 changes: 1 addition & 1 deletion run/logging-manual/test/deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ requireEnv CONTAINER_IMAGE

# Deploy the service
set -x
gcloud beta run deploy "${SERVICE_NAME}" \
gcloud run deploy "${SERVICE_NAME}" \
--image="${CONTAINER_IMAGE}" \
--region="${REGION:-us-central1}" \
--platform=managed \
Expand Down
2 changes: 1 addition & 1 deletion run/logging-manual/test/runner.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ echo
# Only needed if deploy completed.
function cleanup {
set -x
gcloud beta run services delete ${SERVICE_NAME} \
gcloud run services delete ${SERVICE_NAME} \
--platform=managed \
--region="${REGION:-us-central1}" \
--quiet
Expand Down
2 changes: 1 addition & 1 deletion run/logging-manual/test/url.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ requireEnv() {
requireEnv SERVICE_NAME

set -x
gcloud beta run services \
gcloud run services \
describe "${SERVICE_NAME}" \
--region="${REGION:-us-central1}" \
--format='value(status.domain)' \
Expand Down