-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .mocharc to create test XML results. #1588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So here's what I wish we had, for client libraries too, is the ability to have the default mocha
output, in conjunction with the xunit
output, and then we could just always have xunit
outputting to a well known location, e.g. .test/all-tests.xml
, which we don't check in.
We could then enable this on all our repos in a standard way, without moving a file around. This would allow us to take advantage of some of the work @tbpg has done with a "build cop bot".
@fhinkel FYI - @bcoe requested that I apply this change to all tests (as opposed to just the already-labeled tests in This PR will cause two major changes:
@fhinkel - @bcoe was fine with this for the client libraries, but I want to make sure you're OK with this as well before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach, as we'd like to move towards performing analysis on test failures across all of our client libraries -- and it seems like xunit is probably a good way to do so.
My only concern is if the kokoro UI ends up not being easy enough to delve into on failures, it looked fairly reasonable from what @ace-n showed me though.
Merging this now, as it's necessary for a demo next week. @fhinkel if this change becomes an issue for you, please ping me so we can roll back and/or work out an alternative solution. 🙂 |
Sounds good, let's see if it causes any problems (also with the build cop bot). |
Part 2 of #1587
DO NOT MERGE until all test results are (somehow) visible in the Kokoro UI.