Add service-to-service Node.js sample #1704

kelsk · 2020-04-03T18:42:38Z

Refactored snippet from service-to-service guide

Replaced "request" (deprecated) with "got"

googlebot · 2020-04-03T18:42:41Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

kelsk · 2020-04-03T18:45:30Z

@googlebot I signed it!

…

On Fri, Apr 3, 2020, 11:43 AM googlebot ***@***.***> wrote: Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 *Please visit https://cla.developers.google.com/ <https://cla.developers.google.com/> to sign.* Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it. ------------------------------ What to do if you already signed the CLA Individual signers - It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data <https://cla.developers.google.com/clas> and verify that your email is set on your git commits <https://help.github.com/articles/setting-your-email-in-git/>. Corporate signers - Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version <https://opensource.google/docs/cla/#troubleshoot>). - The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data <https://cla.developers.google.com/clas> and verify that your email is set on your git commits <https://help.github.com/articles/setting-your-email-in-git/>. - The email used to register you as an authorized contributor must also be attached to your GitHub account <https://github.com/settings/emails>. ℹ️ *Googlers: Go here <https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2FGoogleCloudPlatform%2Fnodejs-docs-samples%2Fpull%2F1704> for more info*. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1704 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJD7UOSTHS4BWGRBC7M3QSTRKYU3HANCNFSM4L4LTLNA> .

googlebot · 2020-04-03T18:45:40Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

run/authentication/auth.js

averikitsch · 2020-04-03T20:19:44Z

You will also need to add a testing file similar to https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/master/.kokoro/run

Co-Authored-By: Averi Kitsch <[email protected]>

Apply suggested changes

googlebot · 2020-04-06T17:32:23Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

run/authentication/auth.js

run/authentication/package.json

googlebot · 2020-04-06T20:47:28Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

run/authentication/package.json

averikitsch · 2020-05-05T15:53:48Z

run/authentication/test/auth.test.js

+    res = await requestServiceToken('');
+  });
+
+  it('should return an error if given invalid Receiving Service URL', () => {


It would be nice to have a test that passes. When running on kokoro a request to the metadata server should succeed. You could write a test that looks for the env var 'GCLOUD_PROJECT' but make a comment that it must be unset locally.

grayside

This is shaping up nicely, however it's worth noting that there will soon be a change in how we want to approach minting the identity token. Depending on timing this might be a change to this PR or a follow-up, I hope to have a clearer answer on that by EOD.

grayside · 2020-05-05T18:48:53Z

run/authentication/auth.js

+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+const requestServiceToken = async (receivingServiceURL = 'https://SERVICE_NAME-HASH-run.app') => {


Not sure I follow why this function exists? If we're running in an environment that can mint a token, let's write an integration test that mints the token. We can split the request function to something that returns the token from metadata so it can be tested without making an HTTP request, or we can keep this all in one but use request mocking to inspect and validate the token: https://github.com/sindresorhus/got#testing

grayside · 2020-05-05T18:50:55Z

run/authentication/test/auth.test.js

+
+let res;
+
+describe('requestServiceToken tests', () => {


We need some deeper test coverage: can we parse out the auth token and at least do basic validation that it's a proper JWT?

grayside · 2020-05-08T20:56:11Z

The ID Token library changes came together in the last month, have been released, and the Yoshi team was kind enough to create a variant of the idtoken-iap sample for Cloud Run: https://github.com/googleapis/google-auth-library-nodejs/blob/master/samples/idtokens-cloudrun.js.

To avoid duplication of maintenance work and ensure the sample stays aligned with library changes, I think we should prefer using that sample.

Thank you for the PR!

Add service-to-service Node.js sample

9d64ae1

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 3, 2020

averikitsch self-requested a review April 3, 2020 18:54

Add service-to-service Node.js sample

64ab35f

averikitsch requested changes Apr 3, 2020

View reviewed changes

kelsk and others added 5 commits April 3, 2020 14:12

Update run/authentication/auth.js

00451bf

Co-Authored-By: Averi Kitsch <[email protected]>

Update sample to address suggested changes

86b0635

Merge branch 'master' into auth

5132e26

Merge pull request #1 from kelsk/auth

a176376

Apply suggested changes

Merge branch 'master' into master

70ce8f7

averikitsch added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 6, 2020

averikitsch reviewed Apr 6, 2020

View reviewed changes

run/authentication/auth.js Outdated Show resolved Hide resolved

averikitsch reviewed Apr 6, 2020

View reviewed changes

run/authentication/auth.js Outdated Show resolved Hide resolved

averikitsch reviewed Apr 6, 2020

View reviewed changes

run/authentication/package.json Show resolved Hide resolved

Initial code added

5975b57

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 6, 2020

kelsk and others added 6 commits April 13, 2020 15:34

Updated package.json; resolved issues in auth.js from review

8e9ef37

Removed markdown dir from branch

42aa279

Added test

b53d157

tests: added error test

0b6311a

update test for clarity

c46ca0c

update license

30dc7d0

kelsk added 3 commits May 4, 2020 15:07

update author

0279f2a

change syntax & format

a929c05

add run authentication sample

b3d410f

kelsk requested a review from averikitsch May 4, 2020 22:13

kelsk marked this pull request as ready for review May 4, 2020 22:13

averikitsch reviewed May 5, 2020

View reviewed changes

run/authentication/package.json Show resolved Hide resolved

averikitsch reviewed May 5, 2020

View reviewed changes

averikitsch requested a review from grayside May 5, 2020 15:54

grayside requested changes May 5, 2020

View reviewed changes

grayside closed this May 8, 2020

pedroarapua mentioned this pull request Jul 6, 2023

[Snyk] Security upgrade @google-cloud/firestore from 1.3.0 to 6.0.0 pedroarapua/nodejs-docs-samples-gcp#414

Open

leejh3224 mentioned this pull request Jul 6, 2023

[Snyk] Security upgrade @google-cloud/firestore from 0.19.0 to 6.0.0 leejh3224/nodejs-docs-samples#607

Open

dlminvestments mentioned this pull request Jul 6, 2023

[Snyk] Security upgrade @google-cloud/firestore from 4.15.1 to 6.0.0 dlminvestments/nodejs-docs-samples#446

Merged

aqualen mentioned this pull request Jul 7, 2023

[Snyk] Security upgrade @google-cloud/firestore from 4.15.1 to 6.0.0 aqualen/nodejs-docs-samples#114

Open

pedroarapua mentioned this pull request Jul 7, 2023

[Snyk] Security upgrade @google-cloud/firestore from 1.3.0 to 6.0.0 pedroarapua/nodejs-docs-samples-gcp#424

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add service-to-service Node.js sample #1704

Add service-to-service Node.js sample #1704

kelsk commented Apr 3, 2020

googlebot commented Apr 3, 2020

kelsk commented Apr 3, 2020 via email

googlebot commented Apr 3, 2020

averikitsch commented Apr 3, 2020

googlebot commented Apr 6, 2020

googlebot commented Apr 6, 2020

averikitsch May 5, 2020

grayside left a comment

grayside May 5, 2020

grayside May 5, 2020

grayside commented May 8, 2020


		let res;

		describe('requestServiceToken tests', () => {

Add service-to-service Node.js sample #1704

Add service-to-service Node.js sample #1704

Conversation

kelsk commented Apr 3, 2020

googlebot commented Apr 3, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

kelsk commented Apr 3, 2020 via email

googlebot commented Apr 3, 2020

averikitsch commented Apr 3, 2020

googlebot commented Apr 6, 2020

googlebot commented Apr 6, 2020

averikitsch May 5, 2020

Choose a reason for hiding this comment

grayside left a comment

Choose a reason for hiding this comment

grayside May 5, 2020

Choose a reason for hiding this comment

grayside May 5, 2020

Choose a reason for hiding this comment

grayside commented May 8, 2020