Add style section to CONTRIBUTING.md. #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Samples in this repository follow the [Google JavaScript Style | ||
| Guide](http://google.github.io/styleguide/javascriptguide.xml). This is | ||
| enforced using [JSHint](http://jshint.com/docs/). |
There was a problem hiding this comment.
Style is actually enforce using Semistandard
I'd like to point https://github.com/GoogleCloudPlatform/Template/wiki/style.html back to the repositories where the samples should go.
Current coverage is 87.49% (diff: 100%)@@ master #188 diff @@
==========================================
Files 58 58
Lines 2431 2431
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2127 2127
Misses 304 304
Partials 0 0
|
ivanmkc
pushed a commit
that referenced
this pull request
Nov 3, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 8, 2022
grayside
pushed a commit
that referenced
this pull request
Nov 8, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 10, 2022
kweinmeister
pushed a commit
that referenced
this pull request
Nov 18, 2022
docs: update sample to show method inside of async function
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 18, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
NimJay
pushed a commit
that referenced
this pull request
Nov 19, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 19, 2022
jsimonweb
pushed a commit
to jsimonweb/nodejs-docs-samples
that referenced
this pull request
Dec 12, 2022
irataxy
pushed a commit
that referenced
this pull request
Jan 14, 2023
🤖 I have created a release *beep* *boop* --- ## [2.2.0](googleapis/nodejs-video-transcoder@v2.1.0...v2.2.0) (2022-06-29) ### Features * support regapic LRO ([#187](googleapis/nodejs-video-transcoder#187)) ([7924434](googleapis/nodejs-video-transcoder@7924434)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
irataxy
pushed a commit
that referenced
this pull request
Jan 18, 2023
🤖 I have created a release *beep* *boop* --- ## [2.2.0](googleapis/nodejs-video-transcoder@v2.1.0...v2.2.0) (2022-06-29) ### Features * support regapic LRO ([#187](googleapis/nodejs-video-transcoder#187)) ([7924434](googleapis/nodejs-video-transcoder@7924434)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to point https://github.com/GoogleCloudPlatform/Template/wiki/style.html back to the repositories where the samples should go.