Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(securitycenter): add finding sources iam samples #3722

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

rafaelMurata
Copy link
Contributor

Description

b/339808836

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@rafaelMurata rafaelMurata requested review from a team as code owners June 26, 2024 14:11
Copy link

snippet-bot bot commented Jun 26, 2024

Here is the summary of changes.

You are about to add 17 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: securitycenter Issues related to the Security Command Center API. api: workflows Issues related to the Workflows API. labels Jun 26, 2024
@subfuzion

This comment was marked as outdated.

@subfuzion

This comment was marked as resolved.

@subfuzion subfuzion self-requested a review July 18, 2024 16:49
@subfuzion subfuzion assigned subfuzion and unassigned averikitsch Jul 18, 2024
@iennae iennae changed the title feat:add finding sources iam samples feat(securitycenter): add finding sources iam samples Jul 22, 2024
@subfuzion subfuzion force-pushed the finding-souce-iam-samples branch 5 times, most recently from 959dd54 to 7c9cd6d Compare August 19, 2024 16:43
This streamlines the sample and better aligns it with other languages.
@subfuzion subfuzion merged commit f76c2fb into main Aug 20, 2024
12 checks passed
@subfuzion subfuzion deleted the finding-souce-iam-samples branch August 20, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: securitycenter Issues related to the Security Command Center API. api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants