feat: Adding API v2 Bigquery samples #3823
Conversation
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
product-auto-label
bot
added
samples
|
@gemini review |
![code-review-assist-experimental[bot]](https://avatars.githubusercontent.com/in/919852?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request adds API v2 BigQuery samples, which is a valuable addition. The code is well-structured and the tests seem comprehensive. However, there are a few minor suggestions for improvement.
The checklist in the description is not fully completed. Please ensure all boxes are checked and necessary information is provided before merging.
Consider adding a section to the README explaining how to use the new BigQuery export functionality. This would help users understand the purpose of the samples and how to integrate them into their own projects.
| @@ -19,6 +19,7 @@ on: | |||
| - main | |||
| paths: | |||
| - 'security-center/snippets/v1/**' | |||
| - 'security-center/snippets/v2/**' | |||
There was a problem hiding this comment.
This workflow file now includes the v2 snippets, so consider renaming the workflow file to reflect this, or creating a new workflow file specifically for the v2 snippets for better organization.
| @@ -94,5 +94,6 @@ | |||
| "video-intelligence", | |||
| "vision/productSearch", | |||
| "workflows", | |||
| "workflows/invoke-private-endpoint" | |||
| "workflows/invoke-private-endpoint", | |||
| "security-center/snippets/v2" | |||
There was a problem hiding this comment.
Consider adding a short description for this new entry to clarify its purpose.
| bigQueryExportName: bigQueryExportResponse.name, | ||
| untouchedbigQueryExportName: '', | ||
| }; | ||
| console.log('my data bigQueryExport %j', data); |
There was a problem hiding this comment.
While this log statement is helpful for debugging, consider removing it before merging as it might expose sensitive information in the logs.
| 'use strict'; | ||
|
|
||
| /** | ||
| * Demonstrates how to create a new security finding in CSCC. |
There was a problem hiding this comment.
The description for this function mentions creating a security finding, but the code creates a BigQuery export. Please update the description to accurately reflect the function's purpose.
| * Demonstrates how to create a new security finding in CSCC. | |
| /** | |
| * Demonstrates how to create a BigQuery export in CSCC. | |
| */ |
| * Required. Name of the BigQuery export to retrieve. The following list shows | ||
| * some examples of the format: | ||
| * + | ||
| * `organizations/{organization}/locations/{location}/bigQueryExports/{export_id}` | ||
| * + `folders/{folder}/locations/{location}/bigQueryExports/{export_id}` | ||
| * + `projects/{project}locations/{location}/bigQueryExports/{export_id}` |
There was a problem hiding this comment.
The comment mentions retrieving a BigQuery export, but the code updates it. Please correct the comment.
| * Required. Name of the BigQuery export to retrieve. The following list shows | |
| * some examples of the format: | |
| * + | |
| * `organizations/{organization}/locations/{location}/bigQueryExports/{export_id}` | |
| * + `folders/{folder}/locations/{location}/bigQueryExports/{export_id}` | |
| * + `projects/{project}locations/{location}/bigQueryExports/{export_id}` | |
| /** | |
| * Required. Name of the BigQuery export to update. The following list shows | |
| * some examples of the format: | |
| * `organizations/{organization}/locations/{location}/bigQueryExports/{export_id}` | |
| * `folders/{folder}/locations/{location}/bigQueryExports/{export_id}` | |
| * `projects/{project}locations/{location}/bigQueryExports/{export_id}` | |
| */ |
|
@thokalavinod I resubmitted your PR from a local branch so that workflow tests can run (they won't run for forks): #3919. I'm going to close this PR now. Thanks! |
|
Obsoleted by #3847 |
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.