-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add inpainting and outpainting samples and tests #3874
Conversation
Here is the summary of changes. You are about to add 5 region tags.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @irataxy This is a nice PR. I do have a couple of style suggestions for you, however. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @irataxy The updates look good, but unfortunately, tests are failing due to accelerator / machine type / location that you need to resolve.
Done. Those were unrelated tests. |
@irataxy Sorry, I must have missed that this was set to auto-merge, but I didn't intend for this to get merged until I could talk to you about this issues I'm seeing with testing. It's not clear to me if these are related or not to your PR: https://github.com/GoogleCloudPlatform/nodejs-docs-samples/actions/runs/11219828098/job/31186647001?pr=3874#step:9:132 |
Description
Refactor generateImage.js to include parameters. Add all Imagen tests to a single test file.
Fixes b:367438781
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.