Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add inpainting and outpainting samples and tests #3874

Merged
merged 10 commits into from
Oct 7, 2024
Merged

feat: add inpainting and outpainting samples and tests #3874

merged 10 commits into from
Oct 7, 2024

Conversation

irataxy
Copy link
Contributor

@irataxy irataxy commented Sep 21, 2024

Description

Refactor generateImage.js to include parameters. Add all Imagen tests to a single test file.

Fixes b:367438781

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@irataxy irataxy requested review from a team as code owners September 21, 2024 04:30
Copy link

snippet-bot bot commented Sep 21, 2024

Here is the summary of changes.

You are about to add 5 region tags.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: aiplatform Issues related to the AI Platform API. labels Sep 21, 2024
Copy link
Member

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @irataxy This is a nice PR. I do have a couple of style suggestions for you, however. Thanks!

Copy link
Member

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @irataxy The updates look good, but unfortunately, tests are failing due to accelerator / machine type / location that you need to resolve.

@irataxy
Copy link
Contributor Author

irataxy commented Sep 27, 2024

Hi @irataxy The updates look good, but unfortunately, tests are failing due to accelerator / machine type / location that you need to resolve.

Done. Those were unrelated tests.

@irataxy irataxy merged commit d5ba43a into main Oct 7, 2024
30 checks passed
@irataxy irataxy deleted the imagen branch October 7, 2024 16:45
@subfuzion
Copy link
Member

@irataxy Sorry, I must have missed that this was set to auto-merge, but I didn't intend for this to get merged until I could talk to you about this issues I'm seeing with testing. It's not clear to me if these are related or not to your PR: https://github.com/GoogleCloudPlatform/nodejs-docs-samples/actions/runs/11219828098/job/31186647001?pr=3874#step:9:132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants