Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generativeaionvertexai_gemini_translate #3887

Merged
merged 4 commits into from
Oct 7, 2024
Merged

feat: generativeaionvertexai_gemini_translate #3887

merged 4 commits into from
Oct 7, 2024

Conversation

gryczj
Copy link
Contributor

@gryczj gryczj commented Sep 27, 2024 •
edited
Loading

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj requested review from a team as code owners September 27, 2024 13:53
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Sep 27, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: genai labels Sep 27, 2024
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 27, 2024
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 27, 2024
@gryczj gryczj force-pushed the text-translation branch 2 times, most recently from e7b882e to 752f96b Compare September 30, 2024 10:49
@gryczj gryczj changed the title feat: aiplatform_gemini_translate feat: generativeaionvertexai_gemini_translate_gemini_translate Sep 30, 2024
@gryczj gryczj changed the title feat: generativeaionvertexai_gemini_translate_gemini_translate feat: generativeaionvertexai_gemini_translate Sep 30, 2024
gryczj
gryczj commented Sep 30, 2024
View reviewed changes
generative-ai/snippets/test/sendMultiModalPromptWithImage.test.js Outdated
@@ -37,6 +37,6 @@ describe('Generative AI Stream MultiModal with Image', () => {
`node ./sendMultiModalPromptWithImage.js ${projectId} ${location} ${model}`
);
// Ensure that the conversation is what we expect for these images
assert(output.match(/city: Rio de Janeiro, Landmark: Christ the Redeemer/));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2024-09-30 13-14-53
Reason for change: Those assertions sometimes caused errors.

subfuzion
subfuzion approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gryczj Thank you so much for the changes! Very nice! :)

@subfuzion subfuzion merged commit 232f480 into main Oct 7, 2024
32 checks passed
@subfuzion subfuzion deleted the text-translation branch October 7, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subfuzion subfuzion subfuzion approved these changes

Assignees
No one assigned
Labels
api: genai samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gryczj @subfuzion @kokoro-team