[NL] v1 and v1beta2 updates #470

jmdobry · 2017-08-30T20:36:32Z

- move entity-level sentiment samples to v1
- add text classification
- [BLOCKED] update to newest @google-cloud/language package

codecov · 2017-08-30T20:46:26Z

Codecov Report

Merging #470 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #470   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          13       13           
  Lines         458      458           
=======================================
  Hits          445      445           
  Misses         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e83f4c1...27d7bca. Read the comment docs.

dizcology · 2017-09-05T16:46:24Z

language/README.md

-  node analyze.v1beta2.js entity-sentiment-text "President Obama is speaking at the White House."
-  node analyze.v1beta2.js entity-sentiment-file my-bucket       Detects sentiment of entities in gs://my-bucket/file.txt
-  file.txt
+  node analyze.v1beta2.js classify-text "Android is a mobile operating system developed by Google."


This text is too short - currently the API requires 20 tokens to return non-empty results. This limitation might be improved in the future but let's use a longer piece of text for the sample just in case.

dizcology · 2017-09-05T16:50:03Z

language/analyze.v1.js

+function analyzeEntitySentimentOfText (text) {
+  // [START language_entity_sentiment_string]
+  // Imports the Google Cloud client library
+  const language = require('@google-cloud/language').v1beta2();


This should be changed to v1.

dizcology · 2017-09-05T16:50:54Z

language/analyze.v1.js

+function analyzeEntitySentimentInFile (bucketName, fileName) {
+  // [START language_entity_sentiment_file]
+  // Imports the Google Cloud client library
+  const language = require('@google-cloud/language').v1beta2();


This should be changed to v1.

dizcology · 2017-09-05T16:57:05Z

language/analyze.v1beta2.js

+  const Language = require('@google-cloud/language');
+
+  // Creates a client
+  const language = Language.v1beta2();

  // The text to analyze, e.g. "Hello, world!"
  // const text = 'Hello, world!';


Probably use a longer text here too.

dizcology · 2017-09-05T16:58:48Z

language/analyze.v1beta2.js

+  const Language = require('@google-cloud/language');
+
+  // Creates a client
+  const language = Language.v1beta2();


Just wondering what's the difference between these two ways of creating a client?

const Language = require('@google-cloud/language'); const language = Language({ apiVersion: 'v1beta2' });

vs

const Language = require('@google-cloud/language'); const language = Language.v1beta2();

The first one uses the generated v1 client, but points it add the v1beta2 service endpoint. The second one uses the generated v1beta2 client (which points at the v1beta2 service endpoint by default).

…cs-samples into nl

googlebot · 2017-09-19T01:53:33Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

…cs-samples into nl

gguuss · 2017-09-19T15:54:06Z

@jmdobry /fyi squashing and merging, @jabubake and I are covered under the CLA

* Move entity-level sentiment samples to v1. * Add text classification. * Adds longer text to README.

* chore(main): release 3.0.4 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [5.10.0](googleapis/nodejs-security-center@v5.9.0...v5.10.0) (2022-04-11) ### Features * Add iam_binding field to findings attributes. It represents particular IAM bindings, which captures a member's role addition, removal, or state ([#474](googleapis/nodejs-security-center#474)) ([b29893c](googleapis/nodejs-security-center@b29893c)) * Add next_steps field to finding's list of attributes ([#476](googleapis/nodejs-security-center#476)) ([326e8d2](googleapis/nodejs-security-center@326e8d2)) * AuditConfig for IAM v1 ([#470](googleapis/nodejs-security-center#470)) ([2ec070f](googleapis/nodejs-security-center@2ec070f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

jmdobry added 2 commits August 30, 2017 13:25

Move entity-level sentiment samples to v1.

b46c83d

Add text classification.

c49beaf

jmdobry self-assigned this Aug 30, 2017

jmdobry requested a review from dizcology August 30, 2017 20:36

Fixes.

5af566f

jmdobry changed the title ~~[NL] Move entity-level sentiment samples to v1.~~ [NL] v1 and v1beta2 updates Aug 31, 2017

dizcology reviewed Sep 5, 2017

View reviewed changes

jmdobry and others added 2 commits September 18, 2017 18:50

Fixes.

6b2c0e2

Merge branch 'nl' of https://github.com/GoogleCloudPlatform/nodejs-do…

dcd005c

…cs-samples into nl

gguuss added 4 commits September 18, 2017 20:20

Adds longer text to README.

b498633

Adds longer text to README.

be879d1

Merge branch 'nl' of https://github.com/GoogleCloudPlatform/nodejs-do…

0554498

…cs-samples into nl

Merge branch 'master' into nl

27d7bca

gguuss merged commit 5468b07 into master Sep 19, 2017

gguuss deleted the nl branch September 19, 2017 15:54

NimJay pushed a commit that referenced this pull request Nov 10, 2022

[NL] v1 and v1beta2 updates (#470)

51b8700

* Move entity-level sentiment samples to v1. * Add text classification. * Adds longer text to README.

NimJay mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-language #2827

Merged

NimJay pushed a commit that referenced this pull request Nov 10, 2022

[NL] v1 and v1beta2 updates (#470)

6df4e98

* Move entity-level sentiment samples to v1. * Add text classification. * Adds longer text to README.

ace-n mentioned this pull request Nov 14, 2022

migrate code from googleapis/nodejs-scheduler #2848

Closed

ace-n mentioned this pull request Nov 14, 2022

migrate code from googleapis/nodejs-scheduler #2849

Merged

telpirion mentioned this pull request Nov 16, 2022

chore(vision): migrate code from googleapis/nodejs-vision #2858

Merged

telpirion pushed a commit that referenced this pull request Nov 16, 2022

chore: release 1.6.0 (#470)

6c8886d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NL] v1 and v1beta2 updates #470

[NL] v1 and v1beta2 updates #470

jmdobry commented Aug 30, 2017 •

edited

Loading

codecov bot commented Aug 30, 2017 •

edited

Loading

dizcology Sep 5, 2017

dizcology Sep 5, 2017

dizcology Sep 5, 2017

dizcology Sep 5, 2017

dizcology Sep 5, 2017

jmdobry Sep 5, 2017

googlebot commented Sep 19, 2017

gguuss commented Sep 19, 2017

[NL] v1 and v1beta2 updates #470

[NL] v1 and v1beta2 updates #470

Conversation

jmdobry commented Aug 30, 2017 • edited Loading

codecov bot commented Aug 30, 2017 • edited Loading

Codecov Report

dizcology Sep 5, 2017

Choose a reason for hiding this comment

dizcology Sep 5, 2017

Choose a reason for hiding this comment

dizcology Sep 5, 2017

Choose a reason for hiding this comment

dizcology Sep 5, 2017

Choose a reason for hiding this comment

dizcology Sep 5, 2017

Choose a reason for hiding this comment

jmdobry Sep 5, 2017

Choose a reason for hiding this comment

googlebot commented Sep 19, 2017

gguuss commented Sep 19, 2017

jmdobry commented Aug 30, 2017 •

edited

Loading

codecov bot commented Aug 30, 2017 •

edited

Loading