Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong name of commandline parameters in example #497

Merged
merged 1 commit into from
Nov 1, 2017
Merged

wrong name of commandline parameters in example #497

merged 1 commit into from
Nov 1, 2017

Conversation

alexodus
Copy link
Contributor

@alexodus alexodus commented Oct 3, 2017

correct commandline parameters example

@alexodus
Update manager.js
55a13ba 
correct commandline parameters example
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@alexodus
Copy link
Contributor Author

alexodus commented Oct 3, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@jmdobry jmdobry requested a review from gguuss October 24, 2017 21:06
@jmdobry jmdobry added the bug label Oct 24, 2017
gguuss
gguuss approved these changes Nov 1, 2017
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM

@jmdobry jmdobry merged commit 8d12c78 into GoogleCloudPlatform:master Nov 1, 2017
ace-n pushed a commit that referenced this pull request Dec 4, 2017
@alexodus
Update manager.js (#497)
4b2e64d 
correct commandline parameters example
grayside pushed a commit that referenced this pull request Oct 26, 2022
@release-please
chore: release 2.2.0 (#497)
72b1918 
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.2.0](https://www.github.com/googleapis/nodejs-tasks/compare/v2.1.3...v2.2.0) (2021-01-09)


### Features

* introduces style enumeration ([#496](https://www.github.com/googleapis/nodejs-tasks/issues/496)) ([680f1dc](https://www.github.com/googleapis/nodejs-tasks/commit/680f1dcd269d25247a54157108c524f8946dc624))


### Bug Fixes

* **samples:** remove unused variables ([#492](https://www.github.com/googleapis/nodejs-tasks/issues/492)) ([81c4b4e](https://www.github.com/googleapis/nodejs-tasks/commit/81c4b4ece21eb99cec582d3256192de6c402d771))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@grayside grayside mentioned this pull request Oct 26, 2022
Merged
grayside pushed a commit that referenced this pull request Nov 3, 2022
@release-please @grayside
chore: release 2.2.0 (#497)
e7eeb2d 
🤖 I have created a release \*beep\* \*boop\* 
---
## [2.2.0](https://www.github.com/googleapis/nodejs-tasks/compare/v2.1.3...v2.2.0) (2021-01-09)


### Features

* introduces style enumeration ([#496](https://www.github.com/googleapis/nodejs-tasks/issues/496)) ([680f1dc](https://www.github.com/googleapis/nodejs-tasks/commit/680f1dcd269d25247a54157108c524f8946dc624))


### Bug Fixes

* **samples:** remove unused variables ([#492](https://www.github.com/googleapis/nodejs-tasks/issues/492)) ([81c4b4e](https://www.github.com/googleapis/nodejs-tasks/commit/81c4b4ece21eb99cec582d3256192de6c402d771))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@NimJay NimJay mentioned this pull request Nov 11, 2022
Merged
NimJay pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore: release 2.8.1 (#497)
7498e71 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore: release 2.8.1 (#497)
6518266 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 14, 2022
@bcoe
test: remove prettier dep fixing linting (#497)
e066e52
This was referenced Nov 14, 2022
Closed
Merged
grayside pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore: release 2.6.0 (#498)
667b184 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.6.0](https://www.github.com/googleapis/nodejs-cloud-container/compare/v2.5.0...v2.6.0) (2021-12-09)


### Features

* add eslintignore for sameple generated code ([#1302](https://www.github.com/googleapis/nodejs-cloud-container/issues/1302)) ([#497](https://www.github.com/googleapis/nodejs-cloud-container/issues/497)) ([cea38ea](https://www.github.com/googleapis/nodejs-cloud-container/commit/cea38ea9c7b515d133853492ce48de22c843c985))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore: release 2.6.0 (#498)
a558ab2 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.6.0](https://www.github.com/googleapis/nodejs-cloud-container/compare/v2.5.0...v2.6.0) (2021-12-09)


### Features

* add eslintignore for sameple generated code ([#1302](https://www.github.com/googleapis/nodejs-cloud-container/issues/1302)) ([#497](https://www.github.com/googleapis/nodejs-cloud-container/issues/497)) ([cea38ea](https://www.github.com/googleapis/nodejs-cloud-container/commit/cea38ea9c7b515d133853492ce48de22c843c985))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
grayside pushed a commit that referenced this pull request Nov 17, 2022
@release-please @grayside
chore: release 2.6.0 (#498)
5d168f7 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.6.0](https://www.github.com/googleapis/nodejs-cloud-container/compare/v2.5.0...v2.6.0) (2021-12-09)


### Features

* add eslintignore for sameple generated code ([#1302](https://www.github.com/googleapis/nodejs-cloud-container/issues/1302)) ([#497](https://www.github.com/googleapis/nodejs-cloud-container/issues/497)) ([cea38ea](https://www.github.com/googleapis/nodejs-cloud-container/commit/cea38ea9c7b515d133853492ce48de22c843c985))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
@release-please @ahrarmonsur
chore: release 2.6.0 (#498)
98156f7 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.6.0](https://www.github.com/googleapis/nodejs-cloud-container/compare/v2.5.0...v2.6.0) (2021-12-09)


### Features

* add eslintignore for sameple generated code ([#1302](https://www.github.com/googleapis/nodejs-cloud-container/issues/1302)) ([#497](https://www.github.com/googleapis/nodejs-cloud-container/issues/497)) ([cea38ea](https://www.github.com/googleapis/nodejs-cloud-container/commit/cea38ea9c7b515d133853492ce48de22c843c985))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
@JustinBeckwith @bcoe
refactor: use explicit mocha imports (#497)
94af6bf
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
@JustinBeckwith @bcoe
refactor: use explicit mocha imports (#497)
b70649b
@ahrarmonsur ahrarmonsur mentioned this pull request Nov 18, 2022
Merged
NimJay pushed a commit that referenced this pull request Nov 18, 2022
@JustinBeckwith @NimJay
refactor: use explicit mocha imports (#497)
9158515
ace-n pushed a commit that referenced this pull request Nov 21, 2022
@bcoe
test: remove prettier dep fixing linting (#497)
3057895
ace-n pushed a commit that referenced this pull request Nov 21, 2022
@bcoe
test: remove prettier dep fixing linting (#497)
d0416a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gguuss gguuss gguuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexodus @googlebot @gguuss @jmdobry