Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the params sent across to the ga endpoint. #582

Closed
wants to merge 4 commits into from
Closed

fix the params sent across to the ga endpoint. #582

wants to merge 4 commits into from

Conversation

oluomoniyi
Copy link
Contributor

spreading the results allows the endpoint to pick up the individual params. Previous method does not work.
see https://developers.google.com/analytics/devguides/collection/protocol/v1/reference for more

spreading the results allows the endpoint to pick up the individual params. Previous method does not work.
see https://developers.google.com/analytics/devguides/collection/protocol/v1/reference for more
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@oluomoniyi
Copy link
Contributor Author

I have signed it!

add semicolon
@oluomoniyi
Copy link
Contributor Author

added the semicolon

removed silly semi colon!
@ace-n ace-n requested a review from jmdobry March 28, 2018 22:06
@@ -48,7 +48,7 @@ function trackEvent (category, action, label, value, cb) {
};

return got.post('http://www.google-analytics.com/collect', {
form: data
...data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This operator only works in Node v8.6+, but we strive to make sure our samples work with the oldest LTS version of Node, which until the end of April is Node v4. Can you update your PR to be Node v4 compatible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jmdobry,

Makes sense, updated to use Object.assign instead.

@oluomoniyi oluomoniyi closed this Mar 29, 2018
ace-n pushed a commit that referenced this pull request Nov 17, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
Co-authored-by: Justin Beckwith <[email protected]>
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
Co-authored-by: Justin Beckwith <[email protected]>
NimJay pushed a commit that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants