-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken GCP console link #598
Fix broken GCP console link #598
Conversation
Hey, I'm curious about the circleci build and why it fails sometimes. It looks like the 2nd step in dependencies is:
and in failing builds, you get this:
but since the
Maybe we should remove the Just a thought, though this could be a separate issue or PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@campionfellin Thanks so much. Sorry that this was sitting here forever. About the CI: It's not in good shape 😢 All the recent runs didn't even get to that error. |
Ah looks like the build passed... @JustinBeckwith did you change the pipeline recently? Looks like it's still getting this error:
Yet somehow passes all the tests later. |
I haven't changed a thing 🤷♂️ |
🤖 I have created a release \*beep\* \*boop\* --- ### [4.2.7](https://www.github.com/googleapis/nodejs-language/compare/v4.2.6...v4.2.7) (2021-07-12) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#598](https://www.github.com/googleapis/nodejs-language/issues/598)) ([47f9295](https://www.github.com/googleapis/nodejs-language/commit/47f9295ae17d4f9f87c32a40276eb1588f2cca55)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ### [4.2.7](https://www.github.com/googleapis/nodejs-language/compare/v4.2.6...v4.2.7) (2021-07-12) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#598](https://www.github.com/googleapis/nodejs-language/issues/598)) ([47f9295](https://www.github.com/googleapis/nodejs-language/commit/47f9295ae17d4f9f87c32a40276eb1588f2cca55)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This fixes #596
With the link to the Tasks API.
Though note that there are 2 other broken links on that page, and it's hard to tell where they're supposed to go:
Line 3:
[Google Cloud Tasks](https://cloud.google.com/cloud-tasks/)
maybe it should link to:https://cloud.google.com/sdk/gcloud/reference/alpha/tasks/
instead?Line 86:
https://cloud.google.com/cloud-tasks
should be changed similarly.