Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting to Kokoro + deprecate CircleCI #727

Merged
merged 3 commits into from
Aug 30, 2018
Merged

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Aug 30, 2018

Currently linting is handled by CircleCI - this moves it to Kokoro and deprecates CircleCI.

@ace-n ace-n requested a review from fhinkel August 30, 2018 19:24
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2018
@ace-n ace-n changed the title Add linting to Kokoro Add linting to Kokoro + deprecate CircleCI Aug 30, 2018
.kokoro/lint.sh Outdated
npm install

# Run lint
npm lint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this won't run. Use npm run lint.

@ace-n ace-n merged commit bbc3e07 into master Aug 30, 2018
@ace-n ace-n deleted the kokoro-from-circle branch August 30, 2018 20:56
@fhinkel fhinkel mentioned this pull request Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants