Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error logging example #930

Merged
merged 15 commits into from
Mar 2, 2019
Merged

Update error logging example #930

merged 15 commits into from
Mar 2, 2019

Conversation

Mytrill
Copy link
Contributor

@Mytrill Mytrill commented Nov 25, 2018

Add an example of logging an error with both text and an error object.

Add an example of logging an error with both text and an error object.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 25, 2018
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mytrill
Copy link
Contributor Author

Mytrill commented Dec 10, 2018

CLA signed

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 10, 2018
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 14, 2018
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 14, 2018
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 14, 2018
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Dec 14, 2018
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 14, 2018
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 14, 2018
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 15, 2018
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 15, 2018
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 29, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 29, 2019
@JustinBeckwith JustinBeckwith added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 27, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 28, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 28, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Feb 28, 2019

@Mytrill The linter is failing. Could you have a look. Thanks.

@fhinkel fhinkel removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 28, 2019
@fhinkel fhinkel added automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 1, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants