Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to override useragent #322

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Allow users to override useragent #322

merged 1 commit into from
Feb 10, 2022

Conversation

dashpole
Copy link
Contributor

Fixes #289

Options at the end of the list override options earlier in the list of options, so we need to prepend the user agent.

@dashpole dashpole requested a review from punya February 10, 2022 21:02
@dashpole dashpole merged commit 1a8c2c3 into GoogleCloudPlatform:main Feb 10, 2022
@dashpole dashpole deleted the fix_useragent_override branch February 10, 2022 22:13
@renovate renovate bot mentioned this pull request May 3, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@punya punya punya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User-provided useragent is overridden in metrics exporter
2 participants
@dashpole @punya