Log exporter individual log splitting #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damemi
commented
May 11, 2022
exporter/collector/logs.go
Outdated
| internalLogEntry.Resource = mr | ||
| if splits > 1 { | ||
| internalLogEntry.Split = &logpb.LogSplit{ | ||
| Uid: entry.Timestamp.String(), |
There was a problem hiding this comment.
this needs some sort of salt to add more uniqueness. audit logs use a "~unique" process id
| // Calculate the size of the internal log entry so this overhead can be accounted | ||
| // for when determining the need to split based on payload size | ||
| // TODO(damemi): Find an appropriate estimated buffer to account for the LogSplit struct as well | ||
| logOverhead, err := l.logEntryToInternal(entry, logName, mr, 0, 0) |
There was a problem hiding this comment.
it's annoying that I need a duplicate logEntryToInternal call, but we need the size of the proto before the payload is added to calculate the overhead, then we need to convert each complete logentry (w/payload) to a proto. maybe there is an optimization I'm not seeing
dashpole
reviewed
May 11, 2022
dashpole
reviewed
May 12, 2022
exporter/collector/logs.go
Outdated
| continue | ||
| } | ||
| logName, err := l.getLogName(log) | ||
| splitEntries, logName, err := l.logToSplitEntries( |
There was a problem hiding this comment.
we don't need to return logName from this anymore, right?
dashpole
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sizes and splits individual log entries based on the default maximum quotas per cloud logging